Re: [PATCH v3] Xen sched: Fix multiple runqueues in credit2

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1382 bytes --]

On Mon, 2014-02-10 at 08:52 +0000, Jan Beulich wrote:
> >>> On 09.02.14 at 02:57, Justin Weaver <jtweaver@hawaii.edu> wrote:
> > @@ -1959,15 +1961,25 @@ static void init_pcpu(const struct scheduler *ops, int cpu)
> >          return;
> >      }
> >  
> > -    /* Figure out which runqueue to put it in */
> > +    /*
> > +     * Choose which run queue to add cpu to based on its socket.
> > +     * If it's CPU 0, hard code it to run queue 0 (it doesn't get a STARTING
> > +     * callback and socket information is not yet available for it).
> 
> Did you verify that last part to be the case? Because if so, we would
> probably be better off fixing the initialization ordering.
> 
Last part == "socket information is not yet available" ? If yes, yes, at
least on my system, cpu_to_socket() always return 0 (or, if I statically
initialize the array to -1, it always return -1) at that time, and I
have CPU0 on socket 1, so I'm quite sure that is the case.

By fixing the init order, do you mean moving whatever does the
cpu-to-socket mapping before scheduler's initialization?

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel