All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag
Date: Tue, 11 Feb 2014 12:17:01 +0100	[thread overview]
Message-ID: <1392117421.5686.4.camel@x220> (raw)
In-Reply-To: <1409428.L7JLLEda5C@avalon>

Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4
camera interface - Build system") added a Kconfig entry for
VIDEO_OMAP4_DEBUG. But nothing uses that symbol.

This entry was apparently copied from a similar entry for "OMAP 3
Camera debug messages". The OMAP 3 entry is used to set the DEBUG
compiler flag, which enables calls of dev_dbg().

So add a Makefile line to do that for omap4iss too.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) v1 was called "[media] v4l: omap4iss: Remove VIDEO_OMAP4_DEBUG". This
versions implements Laurent's alternative (which is much better).

1) Still untested.

 drivers/staging/media/omap4iss/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/media/omap4iss/Makefile b/drivers/staging/media/omap4iss/Makefile
index a716ce9..f46c6bd 100644
--- a/drivers/staging/media/omap4iss/Makefile
+++ b/drivers/staging/media/omap4iss/Makefile
@@ -1,5 +1,7 @@
 # Makefile for OMAP4 ISS driver
 
+ccflags-$(CONFIG_VIDEO_OMAP4_DEBUG) += -DDEBUG
+
 omap4-iss-objs += \
 	iss.o iss_csi2.o iss_csiphy.o iss_ipipeif.o iss_ipipe.o iss_resizer.o iss_video.o
 
-- 
1.8.5.3


  reply	other threads:[~2014-02-11 11:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-09 15:09 [PATCH] [media] v4l: omap4iss: Remove VIDEO_OMAP4_DEBUG Paul Bolle
2014-02-10 14:13 ` Laurent Pinchart
2014-02-10 15:13   ` Paul Bolle
2014-02-10 15:29     ` Laurent Pinchart
2014-02-11 11:17       ` Paul Bolle [this message]
2014-02-11 12:38         ` [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag Laurent Pinchart
2014-03-05 20:10           ` Mauro Carvalho Chehab
2014-03-05 23:50             ` Laurent Pinchart
2014-03-06  0:28               ` Joe Perches
2014-03-06  0:48                 ` Laurent Pinchart
2014-03-06  1:00                   ` Joe Perches
2014-03-06  1:27                     ` Laurent Pinchart
2014-03-06  1:35                       ` Joe Perches
2014-03-06  1:52                         ` Laurent Pinchart
2014-03-06  3:25                           ` Joe Perches
2014-03-06 10:55                             ` Laurent Pinchart
2014-03-06 16:47                               ` Joe Perches
2014-03-06  4:45                   ` Greg Kroah-Hartman
2014-03-06 10:23                     ` Paul Bolle
2014-03-06 11:00                     ` Laurent Pinchart
2014-03-06 11:59                       ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392117421.5686.4.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.