From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Bolle <pebolle@tiscali.nl>
Subject: drm/msm:  CONFIG_MSM_OCMEM?
Date: Tue, 11 Feb 2014 16:39:41 +0100
Message-ID: <1392133181.3755.14.camel@x220>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
To: Rob Clark <robdclark@gmail.com>
Cc: Richard Weinberger <richard@nod.at>, David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
List-Id: dri-devel@lists.freedesktop.org

Rob,

Commit 55459968176f ("drm/msm: add a330/apq8x74") added preprocessor
checks for CONFIG_MSM_OCMEM. But I couldn't find a Kconfig symbol
MSM_OCMEM (nor a preprocessor define for a macro of that name). Why were
those preprocessor checks added?

Please note that lines 197-201 currently read:
    /* Set the OCMEM base address for A330, etc */
    if (a3xx_gpu->ocmem_hdl) {
            gpu_write(gpu, REG_A3XX_RB_GMEM_BASE_ADDR,
                    (unsigned int)(a3xx_gpu->ocmem_base >> 14));
    }

ocmem_hdl and ocmem_base are used uninitialized here, aren't they? So it
seems these lines should be wrapped with a preprocessor check for
CONFIG_MSM_OCMEM too.


Paul Bolle