From: Johannes Berg <johannes@sipsolutions.net>
To: Calvin Owens <jcalvinowens@gmail.com>
Cc: Joe Perches <joe@perches.com>,
"David S. Miller" <davem@davemloft.net>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] ieee80211: Print human-readable disassoc/deauth reason codes
Date: Wed, 12 Feb 2014 11:46:41 +0100 [thread overview]
Message-ID: <1392202001.4146.11.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20140211183624.GA2291@gmail.com> (sfid-20140211_193654_194490_DD27EA29)
On Tue, 2014-02-11 at 12:36 -0600, Calvin Owens wrote:
> Create a function to return a descriptive string for each reason code,
> and print that in addition to the numeric value in the kernel log. These
> codes are easily found on popular search engines, but one is generally
> not able to access the internet when dealing with wireless connectivity
> issues.
Applied.
> Changes in v2: Refactored array of strings into switch statement.
> Changes in v3: Fix style problem, use simplifying macro for switch
> statement, eliminate temporary enum variable.
> Changes in v4: Move new function to net/mac80211/mlme.c and make it
> static, since all of its callers are there.
I removed all this, it belongs after the --- imho.
> + default: return "<INVALID>";
There are many more valid reason codes that this function doesn't
understand, so <invalid> is misleading, I replaced that by "<unknown>".
johannes
next prev parent reply other threads:[~2014-02-12 10:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 1:44 [PATCH] ieee80211: Print human-readable disassoc/deauth reason codes Calvin Owens
2014-02-06 4:44 ` Joe Perches
2014-02-10 11:09 ` Johannes Berg
2014-02-10 16:39 ` Joe Perches
2014-02-11 1:25 ` [PATCH v2] " Calvin Owens
2014-02-11 1:39 ` Joe Perches
2014-02-11 16:37 ` [PATCH v3] " Calvin Owens
2014-02-11 16:48 ` Antonio Quartulli
2014-02-11 17:59 ` Calvin Owens
2014-02-11 18:19 ` Johannes Berg
2014-02-11 17:13 ` Joe Perches
2014-02-11 17:52 ` Calvin Owens
2014-02-11 18:36 ` [PATCH v4] " Calvin Owens
2014-02-12 10:46 ` Johannes Berg [this message]
2014-02-06 8:37 ` [PATCH] " Johannes Berg
2014-02-07 12:53 ` Kalle Valo
2014-02-07 15:46 ` Larry Finger
2014-02-07 22:25 ` Luca Coelho
2014-02-08 6:38 ` Kalle Valo
2014-02-07 20:50 ` Calvin Owens
2014-02-10 8:50 ` Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392202001.4146.11.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=jcalvinowens@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.