All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sinclair Yeh <sinclair.yeh-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: wayland-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Sinclair Yeh <sinclair.yeh-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: [PATCH] Prevent zero sized wl_egl_window
Date: Wed, 12 Feb 2014 16:21:11 -0800	[thread overview]
Message-ID: <1392250871-3224-1-git-send-email-sinclair.yeh@intel.com> (raw)

It is illegal to create or resize a window to zero (or negative) width
and/or height.  This patch prevents such a request from happening.
---
 src/egl/wayland/wayland-egl/wayland-egl.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/egl/wayland/wayland-egl/wayland-egl.c b/src/egl/wayland/wayland-egl/wayland-egl.c
index 8bd49cf..ae78595 100644
--- a/src/egl/wayland/wayland-egl/wayland-egl.c
+++ b/src/egl/wayland/wayland-egl/wayland-egl.c
@@ -9,6 +9,9 @@ wl_egl_window_resize(struct wl_egl_window *egl_window,
 		     int width, int height,
 		     int dx, int dy)
 {
+	if (width <= 0 || height <= 0)
+		return;
+
 	egl_window->width  = width;
 	egl_window->height = height;
 	egl_window->dx     = dx;
@@ -24,6 +27,9 @@ wl_egl_window_create(struct wl_surface *surface,
 {
 	struct wl_egl_window *egl_window;
 
+	if (width <= 0 || height <= 0)
+		return NULL;
+
 	egl_window = malloc(sizeof *egl_window);
 	if (!egl_window)
 		return NULL;
-- 
1.8.1.4

             reply	other threads:[~2014-02-13  0:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13  0:21 Sinclair Yeh [this message]
     [not found] ` <1392250871-3224-1-git-send-email-sinclair.yeh-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-02-13  8:11   ` [PATCH] Prevent zero sized wl_egl_window Pekka Paalanen
2014-02-13 18:18     ` Yeh, Sinclair
     [not found]       ` <1392315418.3247.29.camel-xjpeL9Jkt2k8a1ujtQqgMq2pdiUAq4bhAL8bYrjMMd8@public.gmane.org>
2014-02-14  7:31         ` Pekka Paalanen
     [not found]           ` <20140214093145.7847a53f-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-18 22:25             ` Kristian Høgsberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392250871-3224-1-git-send-email-sinclair.yeh@intel.com \
    --to=sinclair.yeh-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=wayland-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.