From: Casey Schaufler <casey@schaufler-ca.com>
To: Jan Engelhardt <jengelh@computergmbh.de>,
Casey Schaufler <casey@schaufler-ca.com>
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org
Subject: Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel
Date: Sun, 12 Aug 2007 12:50:44 -0700 (PDT) [thread overview]
Message-ID: <139264.28979.qm@web36601.mail.mud.yahoo.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0708121309530.28963@fbirervta.pbzchgretzou.qr>
--- Jan Engelhardt <jengelh@computergmbh.de> wrote:
> >> >+static int smack_task_movememory(struct task_struct *p)
> >> >+{
> >> >+ int rc;
> >> >+
> >> >+ rc = smk_curacc(smk_of_task(p), MAY_WRITE);
> >> >+ return rc;
> >> >+}
> >>
> >> Uh...
> >>
> >> {
> >> return smk_curacc(smk_of_task(p), MAY_WRITE);
> >> }
> >>
> >> (also others)
> >
> >That was a little excessive, wasn't it?
>
> How do you mean? I was just suggesting to collapse the three [four] lines
> into
> one, getting rid of the tempotemporaries in a lot of these functions,
> for example,
Sorry, I meant that my code was excessive, not your comment.
Your comment was fine and most welcome. I'm sorry that I was
unclear and sounded defensive.
Casey Schaufler
casey@schaufler-ca.com
next prev parent reply other threads:[~2007-08-12 19:50 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-11 17:57 [PATCH] Smack: Simplified Mandatory Access Control Kernel Casey Schaufler
2007-08-11 19:12 ` Arjan van de Ven
2007-08-11 19:56 ` Casey Schaufler
2007-08-12 3:39 ` Keith Owens
2007-08-11 19:18 ` Kyle Moffett
2007-08-11 21:01 ` Casey Schaufler
2007-08-11 21:47 ` Kyle Moffett
2007-08-12 1:21 ` Casey Schaufler
2007-08-12 4:32 ` Kyle Moffett
2007-08-12 19:41 ` Casey Schaufler
2007-08-12 23:18 ` Crispin Cowan
2007-08-13 1:38 ` Kyle Moffett
2007-08-13 2:36 ` Joshua Brindle
2007-08-13 2:45 ` Kyle Moffett
2007-08-13 4:23 ` Casey Schaufler
2007-08-16 20:58 ` Pavel Machek
2007-08-17 4:56 ` Casey Schaufler
2007-08-17 9:46 ` Miguel Ojeda
2007-08-18 5:29 ` Kyle Moffett
2007-08-19 21:12 ` Valdis.Kletnieks
2007-08-21 13:16 ` Kyle Moffett
2007-08-21 15:50 ` Casey Schaufler
2007-08-22 3:43 ` Kyle Moffett
2007-08-22 4:08 ` Casey Schaufler
2007-09-07 16:02 ` Casey Schaufler
2007-08-20 14:29 ` Casey Schaufler
2007-08-21 7:37 ` Pavel Machek
2007-08-21 15:35 ` Casey Schaufler
2007-08-22 8:05 ` Pavel Machek
2007-08-22 18:47 ` Casey Schaufler
2007-08-23 7:14 ` Jan Engelhardt
2007-08-11 20:26 ` Jan Engelhardt
2007-08-11 23:22 ` Casey Schaufler
2007-08-12 11:16 ` Jan Engelhardt
2007-08-12 19:50 ` Casey Schaufler [this message]
2007-08-11 23:14 ` Andi Kleen
2007-08-12 1:36 ` Casey Schaufler
2007-08-12 11:49 ` Andi Kleen
2007-08-12 17:48 ` Casey Schaufler
2007-08-12 21:36 ` Andi Kleen
2007-08-12 21:46 ` Casey Schaufler
2007-08-12 3:45 ` Keith Owens
2007-08-12 17:16 ` Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=139264.28979.qm@web36601.mail.mud.yahoo.com \
--to=casey@schaufler-ca.com \
--cc=akpm@osdl.org \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.