All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Jonathan Liu <net147@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] lib/oe/image.py: fix working directory
Date: Tue, 18 Feb 2014 08:41:35 +0000	[thread overview]
Message-ID: <1392712895.14081.197.camel@ted> (raw)
In-Reply-To: <1392633988-14208-1-git-send-email-net147@gmail.com>

On Mon, 2014-02-17 at 21:46 +1100, Jonathan Liu wrote:
> The working directory needs to be changed before the image creation
> commands instead of afterwards.
> 
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>  meta/lib/oe/image.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/lib/oe/image.py b/meta/lib/oe/image.py
> index c15296f..31193f2 100644
> --- a/meta/lib/oe/image.py
> +++ b/meta/lib/oe/image.py
> @@ -176,8 +176,8 @@ class Image(object):
>              bb.data.update_data(localdata)
>              localdata.setVar('type', type)
>  
> -            cmds.append("\t" + localdata.getVar("IMAGE_CMD", True))
>              cmds.append(localdata.expand("\tcd ${DEPLOY_DIR_IMAGE}"))
> +            cmds.append("\t" + localdata.getVar("IMAGE_CMD", True))
>  
>              if type in cimages:
>                  for ctype in cimages[type]:

I applied this but ended up reverting it since its clear the image
commands assume a different working directory and this causes failures.

I'd like to see more explanation about the problem this is trying to
solve.

Cheers,

Richard



  reply	other threads:[~2014-02-18  8:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17 10:46 [PATCH] lib/oe/image.py: fix working directory Jonathan Liu
2014-02-18  8:41 ` Richard Purdie [this message]
2014-02-18  8:55   ` Jonathan Liu
2014-02-18  9:11     ` Jonathan Liu
2014-02-18  9:55       ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392712895.14081.197.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=net147@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.