From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [OSSTest] standalone-reset: actually honour '-f' option Date: Tue, 18 Feb 2014 12:36:22 +0100 Message-ID: <1392723382.32038.495.camel@Solace> References: <1391005955.21756.7.camel@Abyss> <1392401513.32038.348.camel@Solace> <21246.25423.419772.949039@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4086905968455837331==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WFiyS-00020k-Gh for xen-devel@lists.xenproject.org; Tue, 18 Feb 2014 11:36:28 +0000 In-Reply-To: <21246.25423.419772.949039@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Ian Campbell , xen-devel List-Id: xen-devel@lists.xenproject.org --===============4086905968455837331== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-86OFeTQ+cmJ+ui9gc8rp" --=-86OFeTQ+cmJ+ui9gc8rp Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On ven, 2014-02-14 at 18:41 +0000, Ian Jackson wrote: > Dario Faggioli writes ("Re: [Xen-devel] [OSSTest] standalone-reset: actua= lly honour '-f' option"): > > On mer, 2014-01-29 at 14:32 +0000, Dario Faggioli wrote: > > > standalone-reset's usage says: > > > =20 > > > usage: ./standalone-reset [] [ [ []]] > > > branch and xenbranch default, separately, to xen-unstable > > > options: > > > -f generate flight "flight", default is "standalone" > > > =20 > > > but then there is no place where '-f' is processed, and hence > > > no real way to pass a specific flight name to make-flight. > > > =20 > > > Signed-off-by: Dario Faggioli > > Right. I don't use standalone mode much, so sorry about that. > I know... That's fine. :-) > This patch leads me to an observation: I looked at the code in > standalone-reset and it appears to me that there is not currently > anything which sets "$flight". >=20 Indeed, that's what this does. > So the "DELETE" statements used if there's an existing db won't have > any effect. This doesn't cause any strange effects because > Osstest/JobDB/Standalone.pm deletes them too. >=20 > I think it would be best to delete that part of standalone-reset. Do > you agree ? >=20 Well, if it's either never invoked (right now, without this patch) or duplicate (with this patch), I certainly think it can be removed. I'll send a patch to that effect. > In the meantime I have added your patch to my queue branch. >=20 Ok, thanks. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-86OFeTQ+cmJ+ui9gc8rp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlMDRbYACgkQk4XaBE3IOsS67ACfdrNordUkbwIVQenepXowQ6dO tmgAoJC7005Nh4q9LmGLIwroqyxifFgC =38gV -----END PGP SIGNATURE----- --=-86OFeTQ+cmJ+ui9gc8rp-- --===============4086905968455837331== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4086905968455837331==--