All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaron Brown <aaron.f.brown@intel.com>
To: Joe Perches <joe@perches.com>
Cc: davem@davemloft.net, Mitch Williams <mitch.a.williams@intel.com>,
	netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
	Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [net-next 05/14 v2] i40evf: fix up strings in init task
Date: Wed, 19 Feb 2014 20:51:27 -0800	[thread overview]
Message-ID: <1392871887.2629.10.camel@localhost> (raw)
In-Reply-To: <1392869350.24844.22.camel@joe-AO722>

On Wed, 2014-02-19 at 20:09 -0800, Joe Perches wrote:
> On Wed, 2014-02-19 at 19:49 -0800, Aaron Brown wrote:
> > Make sure errors are reported at the correct log level, quit printing
> > the function name every time, and make the messages more consistent in
> > format.
> []
> > diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> []
> > @@ -2041,9 +2038,8 @@ static void i40evf_init_task(struct work_struct *work)
> >  
> >  	/* The HW MAC address was set and/or determined in sw_init */
> >  	if (!is_valid_ether_addr(adapter->hw.mac.addr)) {
> > -		dev_info(&pdev->dev,
> > -			"Invalid MAC address %pMAC, using random\n",
> > -			adapter->hw.mac.addr);
> > +		dev_info(&pdev->dev, "Invalid MAC address %pMAC, using random\n",
> > +			 adapter->hw.mac.addr);
> 
> The "AC" after %pM is superfluous.

Thanks Joe, guess I'll be making another spin...

  reply	other threads:[~2014-02-20  4:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-20  3:49 [net-next 00/14 v2] 05/14 respun Aaron Brown
2014-02-20  3:49 ` [net-next 05/14 v2] i40evf: fix up strings in init task Aaron Brown
2014-02-20  4:09   ` Joe Perches
2014-02-20  4:51     ` Aaron Brown [this message]
2014-02-20  4:58       ` Joe Perches
2014-02-20  5:16         ` Aaron Brown
2014-02-20 16:20           ` Williams, Mitch A
2014-02-20  6:23 ` [net-next 00/14 v2] 05/14 respun David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392871887.2629.10.camel@localhost \
    --to=aaron.f.brown@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=joe@perches.com \
    --cc=mitch.a.williams@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.