From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH V2] Change ACPI IPMI support to "default y" Date: Thu, 20 Feb 2014 20:46:04 +0000 Message-ID: <1392929163.20109.5.camel@x230> References: <1392740909-2079-1-git-send-email-matthew.garrett@nebula.com> <20140220201458.GA7099@sgi.com> <1392927381.20109.0.camel@x230> <20140220204028.GJ17949@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20140220204028.GJ17949@sgi.com> Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org To: "rja@sgi.com" Cc: "lenb@kernel.org" , "linux-kernel@vger.kernel.org" , "minyard@acm.org" , "rjw@rjwysocki.net" , "linux-acpi@vger.kernel.org" List-Id: linux-acpi@vger.kernel.org T24gVGh1LCAyMDE0LTAyLTIwIGF0IDE0OjQwIC0wNjAwLCBSdXNzIEFuZGVyc29uIHdyb3RlOg0K DQo+IFdoeSBidWlsZCBhIGRyaXZlciBpbnRvIHRoZSBrZXJuZWw/DQoNCkJlY2F1c2UgaXQgcHJv dmlkZXMgZnVuY3Rpb25hbGl0eSB0aGF0IG90aGVyIGRyaXZlcnMgbWF5IG5lZWQgd2l0aG91dA0K dGhlcmUgYmVpbmcgYW55IG1lY2hhbmlzbSB0byBwcm92aWRlIGFuIGV4cGxpY2l0IGRlcGVuZGVu Y3kuIFRoZSBzYW1lDQpyZWFzb24gd2UgYnVpbGQgdGhlIEFDUEkgZW1iZWRkZWQgY29udHJvbGxl ciBkcml2ZXIgaW50byB0aGUga2VybmVsLg0KDQo+IFRoZSByZWFzb24gaXBtaV9zaSBpcyANCj4g YSBkcml2ZXIgaXMgc28gc3lzdGVtcyB0aGF0IHdhbnQgaXQgY2FuIGxvYWQgaXQgYW5kIHN5c3Rl bXMNCj4gdGhhdCBkbyBub3Qgd2FudCBpdCBkbyBub3QgaGF2ZSB0byBsb2FkIGl0LiAgUGx1cyB5 b3UgY2FuDQo+IHN0b3Avc3RhcnQgbW9kdWxlcyB3aXRob3V0IHJlYm9vdGluZy4gIFlvdSBjYW4g Y2hhbmdlIG1vZHVsZQ0KPiBwYXJhbWV0ZXJzIHdpdGhvdXQgcmVib290aW5nLg0KDQpZb3UgY2Fu IGNoYW5nZSBtb2R1bGUgcGFyYW1ldGVycyB3aXRob3V0IHJlYm9vdGluZyBhbnl3YXkgLSB0aGVy ZSdzIGFuDQppbnRlcmZhY2UgZm9yIGl0IGluIHN5c2ZzLg0KDQo+IFRoZXJlIGFyZSBhbnkgbnVt YmVyIG9mIHJlYXNvbnMgd2h5IGEgQk1DIG1heSBub3QgcmVzcG9uZC4NCj4gQk1DcyBhcmUgbm90 b3Jpb3VzIGZvciBiZWluZyBmbGFrZXksIHdpdGggZGlmZmVyZW50IHR5cGVzDQo+IG9mIEJNQ3Mg dGhhdCBtYXkgb3IgbWF5IG5vdCBiZSByZWxpYWJsZS4gIFlvdSBkbyBub3Qgd2FudA0KPiB0byBt YWtlIHRoZSBrZXJuZWwgYm9vdCBkZXBlbmRlbnQgb24gYW4gdW5yZWxpYWJsZSBjb21wb25lbnQu DQoNCllvdSBhcHBlYXIgdG8gYmUgc2F5aW5nICJTR0kgc2hpcCBoYXJkd2FyZSB0aGF0IGRvZXNu J3Qgd29yay4gV2UgZG9uJ3QNCmtub3cgd2h5IGl0IGRvZXNuJ3Qgd29yayBhbmQgd2UncmUgbm90 IGludGVyZXN0ZWQgaW4gZml4aW5nIGl0LCBzbyB3ZSdkDQpwcmVmZXIgdGhlIGRlZmF1bHQga2Vy bmVsIGNvbmZpZ3VyYXRpb24gdG8gYmUgYnJva2VuIi4gVGhhdCBkb2Vzbid0IHNlZW0NCmxpa2Ug YW4gZXNwZWNpYWxseSBjb21wZWxsaW5nIGFyZ3VtZW50Lg0KDQo+IFRoaXMgaXMgYWxzbyBhIHBy b2JsZW0gZm9yIHN5c3RlbXMgd2l0aCBmdW5jdGlvbmFsIEJNQ3MuICBPdXINCj4gbGFyZ2UgY2x1 c3RlciBzeXN0ZW1zIGRvIGFsbCBJUE1JIHRyYWZmaWMgKG1vbml0b3JpbmcpIHRocm91Z2gNCj4g YSBzeXN0ZW0gY29udHJvbGxlciBiYWNrIGRvb3IuICBXZSBkbyBub3Qgd2FudCB0aGUga2VybmVs DQo+IGRvaW5nIElQTUkgY29tbWFuZHMgb24gdGhvc2Ugc3lzdGVtcy4NCg0KV2h5IG5vdD8NCg0K LS0gDQpNYXR0aGV3IEdhcnJldHQgPG1hdHRoZXcuZ2FycmV0dEBuZWJ1bGEuY29tPg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754043AbaBTUqV (ORCPT ); Thu, 20 Feb 2014 15:46:21 -0500 Received: from mail-bl2lp0206.outbound.protection.outlook.com ([207.46.163.206]:5601 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753971AbaBTUqT (ORCPT ); Thu, 20 Feb 2014 15:46:19 -0500 From: Matthew Garrett To: "rja@sgi.com" CC: "lenb@kernel.org" , "linux-kernel@vger.kernel.org" , "minyard@acm.org" , "rjw@rjwysocki.net" , "linux-acpi@vger.kernel.org" Subject: Re: [PATCH V2] Change ACPI IPMI support to "default y" Thread-Topic: [PATCH V2] Change ACPI IPMI support to "default y" Thread-Index: AQHPLMZ9xGM3QUTlOk+rIS3zgvGkBZq+l00AgAAHJxWAAAGIgA== Date: Thu, 20 Feb 2014 20:46:04 +0000 Message-ID: <1392929163.20109.5.camel@x230> References: <1392740909-2079-1-git-send-email-matthew.garrett@nebula.com> <20140220201458.GA7099@sgi.com> <1392927381.20109.0.camel@x230> <20140220204028.GJ17949@sgi.com> In-Reply-To: <20140220204028.GJ17949@sgi.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2001:470:1f07:1371:6267:20ff:fec3:2318] x-forefront-prvs: 01283822F8 x-forefront-antispam-report: SFV:NSPM;SFS:(10009001)(6009001)(377424004)(189002)(199002)(24454002)(49866001)(47976001)(50986001)(56776001)(4396001)(47736001)(76482001)(53806001)(51856001)(54316002)(54356001)(95416001)(92566001)(94316002)(69226001)(85852003)(83072002)(46102001)(93136001)(92726001)(94946001)(86362001)(93516002)(80022001)(65816001)(80976001)(19580405001)(59766001)(19580395003)(77982001)(83322001)(2656002)(76786001)(85306002)(90146001)(74366001)(56816005)(81542001)(63696002)(79102001)(77096001)(81816001)(81686001)(47446002)(33646001)(81342001)(33716001)(74876001)(74706001)(31966008)(74662001)(74502001)(87936001)(87266001)(76796001)(95666003)(3826001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR05MB421;H:BN1PR05MB423.namprd05.prod.outlook.com;CLIP:2001:470:1f07:1371:6267:20ff:fec3:2318;FPR:BCF6F635.2C3552E1.F3F02B8A.8AEAD2A0.20270;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: nebula.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s1KKkRZk021420 On Thu, 2014-02-20 at 14:40 -0600, Russ Anderson wrote: > Why build a driver into the kernel? Because it provides functionality that other drivers may need without there being any mechanism to provide an explicit dependency. The same reason we build the ACPI embedded controller driver into the kernel. > The reason ipmi_si is > a driver is so systems that want it can load it and systems > that do not want it do not have to load it. Plus you can > stop/start modules without rebooting. You can change module > parameters without rebooting. You can change module parameters without rebooting anyway - there's an interface for it in sysfs. > There are any number of reasons why a BMC may not respond. > BMCs are notorious for being flakey, with different types > of BMCs that may or may not be reliable. You do not want > to make the kernel boot dependent on an unreliable component. You appear to be saying "SGI ship hardware that doesn't work. We don't know why it doesn't work and we're not interested in fixing it, so we'd prefer the default kernel configuration to be broken". That doesn't seem like an especially compelling argument. > This is also a problem for systems with functional BMCs. Our > large cluster systems do all IPMI traffic (monitoring) through > a system controller back door. We do not want the kernel > doing IPMI commands on those systems. Why not? -- Matthew Garrett {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I