From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Gary Thomas <gary@mlbassoc.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] security-flags: Deal with powerpc build issues
Date: Wed, 26 Feb 2014 12:00:46 +0000 [thread overview]
Message-ID: <1393416046.31769.111.camel@ted> (raw)
In-Reply-To: <530DD29A.9030807@mlbassoc.com>
On Wed, 2014-02-26 at 04:40 -0700, Gary Thomas wrote:
> On 2014-02-26 04:35, Richard Purdie wrote:
> >
> >
> > Building powerpc machines with the standard security flags generated numerous
> > build failures. Use a reduced set of flags for now to avoid linker issues
> > and other compile failures.
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> > diff --git a/meta/conf/distro/include/security_flags.inc b/meta/conf/distro/include/security_flags.inc
> > index e7d4933a..b5489d8 100644
> > --- a/meta/conf/distro/include/security_flags.inc
> > +++ b/meta/conf/distro/include/security_flags.inc
> > @@ -2,6 +2,14 @@ SECURITY_CFLAGS ?= "-fstack-protector-all -pie -fpie -D_FORTIFY_SOURCE=2"
> > SECURITY_NO_PIE_CFLAGS ?= "-fstack-protector-all -D_FORTIFY_SOURCE=2"
> > SECURITY_LDFLAGS ?= "-Wl,-z,relro,-z,now"
> >
> > +# powerpc does not get on with pie for reasons not looked into as yet
> > +SECURITY_CFLAGS_powerpc = "-fstack-protector-all -D_FORTIFY_SOURCE=2"
> > +# Deal with ppc specific linker failures when using the cflags
> > +SECURITY_CFLAGS_pn-dbus_powerpc = ""
> > +SECURITY_CFLAGS_pn-dbus-ptest_powerpc = ""
> > +SECURITY_CFLAGS_pn-libmatchbox_powerpc = ""
> > +SECURITY_CFLAGS_pn-webkit-gtk = ""
>
> The change for webkit doesn't seem to be PowerPC specific? If it needs
> to be here, shouldn't it be in a separate change, or at least documented
> in the change log?
Sorry, I'll make that powerpc specific, it was meant to be...
Cheers,
Richard
prev parent reply other threads:[~2014-02-26 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 11:35 [PATCH] security-flags: Deal with powerpc build issues Richard Purdie
2014-02-26 11:40 ` Gary Thomas
2014-02-26 12:00 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393416046.31769.111.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=gary@mlbassoc.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.