From: Aaron Brown <aaron.f.brown@intel.com>
To: davem@davemloft.net
Cc: Emil Tantilov <emil.s.tantilov@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Aaron Brown <aaron.f.brown@intel.com>
Subject: [net-next 5/6] ixgbevf: fix handling of tx checksumming
Date: Thu, 27 Feb 2014 20:32:44 -0800 [thread overview]
Message-ID: <1393561965-3688-6-git-send-email-aaron.f.brown@intel.com> (raw)
In-Reply-To: <1393561965-3688-1-git-send-email-aaron.f.brown@intel.com>
From: Emil Tantilov <emil.s.tantilov@intel.com>
This patch resolves an issue introduced by:
commit 7ad1a093519e37fb673579819bf6af122641c397
ixgbevf: make the first tx_buffer a repository for most of the skb info
Incorrect check for the result of ixgbevf_tso() can lead to calling
ixgbevf_tx_csum() which can spawn 2 context descriptors and result in
performance degradation and/or corrupted packets.
Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Aaron Brown <aaron.f.brown@intel.com>
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index a6af7b7..79023ba 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -3155,7 +3155,7 @@ static int ixgbevf_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
tso = ixgbevf_tso(tx_ring, first, &hdr_len);
if (tso < 0)
goto out_drop;
- else
+ else if (!tso)
ixgbevf_tx_csum(tx_ring, first);
ixgbevf_tx_map(tx_ring, first, hdr_len);
--
1.8.5.GIT
next prev parent reply other threads:[~2014-02-28 4:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 4:32 [net-next 0/6] Intel Wired LAN Driver Updates Aaron Brown
2014-02-28 4:32 ` [net-next 1/6] ixgbe: fix to use correct timeout interval for memory read completion Aaron Brown
2014-02-28 4:32 ` [net-next 2/6] ixgbe: collect all 82599 AUTOC code in one function Aaron Brown
2014-02-28 4:32 ` [net-next 3/6] ixgbe: fix bit toggled for 82599 reset fix Aaron Brown
2014-02-28 4:32 ` [net-next 4/6] ixgbe: Add check for FW veto bit Aaron Brown
2014-02-28 4:32 ` Aaron Brown [this message]
2014-02-28 4:32 ` [net-next 6/6] ixgbevf: add check for CHECKSUM_PARTIAL when doing TSO Aaron Brown
2014-02-28 5:41 ` [net-next 0/6] Intel Wired LAN Driver Updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393561965-3688-6-git-send-email-aaron.f.brown@intel.com \
--to=aaron.f.brown@intel.com \
--cc=davem@davemloft.net \
--cc=emil.s.tantilov@intel.com \
--cc=gospo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.