From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 0/4] mfd: sec: Add support for S2MPS14 Date: Fri, 28 Feb 2014 12:05:26 +0100 Message-ID: <1393585526.31997.1.camel@AMDC1943> References: <1393584104-18912-1-git-send-email-k.kozlowski@samsung.com> <20140228104927.GB31720@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:15801 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751296AbaB1LFh (ORCPT ); Fri, 28 Feb 2014 06:05:37 -0500 In-reply-to: <20140228104927.GB31720@lee--X1> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Lee Jones Cc: Sangbeom Kim , Samuel Ortiz , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Tomasz Figa On Fri, 2014-02-28 at 10:49 +0000, Lee Jones wrote: > > Few days ago I sent patches adding support for S2MPS14 device to the > > sec-core/s2mps11 drivers. These patches were rather large as they covered > > multiple subsystems so I decided to split everything into smaller, separate > > patches. > > > > The original patchset (version 3) can be found here: > > http://thread.gmane.org/gmane.linux.kernel.samsung-soc/27194/focus=1649217 > > > > This patchset is a small subset of the patchset related to the MFD core > > driver. It adds support for the S2MPS14 device only to the MFD core driver. > > I already obtained acks from Lee Jones during previous reviews. > > > > The patchset is based on current Linus' tree *with* patch: > > mfd: sec-core: Fix possible NULL pointer dereference when i2c_new_dummy error > > (which is already in Lee Jones' MFD tree) > > Can all of these patches be applied as they are? > > Is anything going to break as a result? Yes, they can be applied as they are. That was the reason behind splitting everything. Nothing should break, as far as I reviewed this and tested. Best regards, Krzysztof > > > Krzysztof Kozlowski (4): > > mfd: sec: Add maximum RTC register for regmap config > > mfd: sec: Select different RTC regmaps for devices > > mfd: sec: Use consistent S2MPS11 RTC alarm interrupt indexes > > mfd: sec: Add support for S2MPS14 > > > > drivers/mfd/sec-core.c | 57 ++++++++++++- > > drivers/mfd/sec-irq.c | 97 ++++++++++++++++++++-- > > include/linux/mfd/samsung/core.h | 1 + > > include/linux/mfd/samsung/irq.h | 31 ++++++- > > include/linux/mfd/samsung/rtc.h | 57 +++++++++++-- > > include/linux/mfd/samsung/s2mps14.h | 152 +++++++++++++++++++++++++++++++++++ > > 6 files changed, 378 insertions(+), 17 deletions(-) > > create mode 100644 include/linux/mfd/samsung/s2mps14.h > > >