From: Dean Anderson <linux-dev@sensoray.com>
To: hverkuil@xs4all.nl, kbuild@01.org, dan.carpenter@oracle.com,
m.chehab@samsung.com, linux-dev@sensoray.com,
linux-media@vger.kernel.org
Subject: [PATCH] s2255drv: urgent memory leak fix.
Date: Fri, 28 Feb 2014 14:19:44 -0800 [thread overview]
Message-ID: <1393625984-4276-1-git-send-email-linux-dev@sensoray.com> (raw)
Critical bug fix. Fixes memory leak introduced by
commit 47d8c881c304642a68d398b87d9e8846e643c81a.
Signed-off-by: Dean Anderson <linux-dev@sensoray.com>
---
drivers/media/usb/s2255/s2255drv.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c
index ef66b1b..4964194 100644
--- a/drivers/media/usb/s2255/s2255drv.c
+++ b/drivers/media/usb/s2255/s2255drv.c
@@ -2175,11 +2175,6 @@ static int s2255_stop_acquire(struct s2255_vc *vc)
mutex_lock(&dev->cmdlock);
chn_rev = G_chnmap[vc->idx];
- buffer = kzalloc(512, GFP_KERNEL);
- if (buffer == NULL) {
- dev_err(&dev->udev->dev, "out of mem\n");
- return -ENOMEM;
- }
/* send the stop command */
buffer[0] = IN_DATA_TOKEN;
buffer[1] = (__le32) cpu_to_le32(chn_rev);
--
1.7.9.5
reply other threads:[~2014-02-28 22:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393625984-4276-1-git-send-email-linux-dev@sensoray.com \
--to=linux-dev@sensoray.com \
--cc=dan.carpenter@oracle.com \
--cc=hverkuil@xs4all.nl \
--cc=kbuild@01.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.