From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Chris Larson <clarson@kergoth.com>
Cc: bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH] fetch/git: Separate out an ls-remote function
Date: Sun, 02 Mar 2014 17:26:48 +0000 [thread overview]
Message-ID: <1393781208.22581.1.camel@ted> (raw)
In-Reply-To: <CABcZANnkVHatSbYqJAL3ZR6uKORYB=1hdBiwZOUXfCad4S2T8w@mail.gmail.com>
On Sat, 2014-03-01 at 21:50 -0700, Chris Larson wrote:
>
> On Fri, Feb 28, 2014 at 10:22 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> - def _latest_revision(self, ud, d, name):
> + def __lsremote(self, ud, d, search):
>
>
> Are we sure we want to use __ here? Double-underscore will trigger
> python internal name mangling. While using it doesn't break anything,
> it doesn't really buy us much either vs _, and makes inspection of the
> class/object rather ugly, IMO :)
>
Agreed, I changed it before merging.
Cheers,
Richard
prev parent reply other threads:[~2014-03-02 17:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 17:22 [PATCH] fetch/git: Separate out an ls-remote function Richard Purdie
2014-03-02 4:50 ` Chris Larson
2014-03-02 17:26 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393781208.22581.1.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=clarson@kergoth.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.