From: Phil Blundell <pb@pbcl.net>
To: nitin.a.kamble@intel.com
Cc: Openembedded-core@lists.openembedded.org, saul.wold@intel.com
Subject: Re: [PATCH 1/1] QA_check: special case kernel modules for x32 targets
Date: Tue, 04 Mar 2014 21:38:11 +0000 [thread overview]
Message-ID: <1393969091.4151.3.camel@e130.pbcl.net> (raw)
In-Reply-To: <a63693d8974ab55ba1031cf36302f28c4cc86c22.1393957379.git.nitin.a.kamble@intel.com>
On Tue, 2014-03-04 at 10:28 -0800, nitin.a.kamble@intel.com wrote:
> - ("virtual/kernel" in provides) and (target_os == "linux-gnux32")):
> + (("virtual/kernel" in provides) or (KERNEL_MODULE_RECIPE == "1")) and (target_os == "linux-gnux32")):
Can you not use bb.data.inherits_class("module") rather than adding this
extra variable?
Also, out of curiosity, I don't entirely understand how the code above
can possibly work. KERNEL_MODULE_RECIPE is a bitbake variable that's
either defined to 1 or not defined at all, right? Is there some special
magic nowadays that allows you to refer to it transparently from python
code without using d.getVar()?
p.
next prev parent reply other threads:[~2014-03-04 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 18:27 [PATCH 0/1] A QA_check fix for x32 kernel module packages nitin.a.kamble
2014-03-04 18:28 ` [PATCH 1/1] QA_check: special case kernel modules for x32 targets nitin.a.kamble
2014-03-04 21:38 ` Phil Blundell [this message]
2014-03-04 22:26 ` Kamble, Nitin A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393969091.4151.3.camel@e130.pbcl.net \
--to=pb@pbcl.net \
--cc=Openembedded-core@lists.openembedded.org \
--cc=nitin.a.kamble@intel.com \
--cc=saul.wold@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.