Re: [PATCH 2/4] libxc: report how much memory a domain has on each NUMA node

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1383 bytes --]

On mer, 2014-03-05 at 15:05 +0000, Andrew Cooper wrote:
> On 05/03/14 14:36, Dario Faggioli wrote:

> > diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
> > index 369c3f3..a2b3c07 100644
> > --- a/tools/libxc/xc_domain.c
> > +++ b/tools/libxc/xc_domain.c
> > @@ -362,6 +362,34 @@ int xc_domain_getinfo(xc_interface *xch,
> >      return nr_doms;
> >  }
> >  
> > +int xc_domain_numainfo(xc_interface *xch, uint32_t domid,
> > +                       int *max_nodes, uint64_t *memkbs)
> 
> max_nodes is an unsigned quantity.  libxc is quite fast and loose with
> this, but lets not propage wrongness.
> 
True. The bummer is that, as discussed already for other reasons, if I
want to use the value returned from libxl_get_max_nodes() as max_nodes,
that's an integer.

Anyway, I'll work around that, I guess.

> > +{
> > +    DECLARE_DOMCTL;
> > +    DECLARE_HYPERCALL_BOUNCE(memkbs, sizeof(uint64_t) * (*max_nodes),
> > +                             XC_HYPERCALL_BUFFER_BOUNCE_OUT);
> > +    int ret = 0;
> 
> Don't need the initialiser.
> 
Ok.

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel