All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: <linux-mtd@lists.infradead.org>
Cc: Kent Li <kent.li@radisys.com>,
	Elie De Brauwer <eliedebrauwer@gmail.com>,
	Artem Bityutskiy <dedekind1@gmail.com>,
	HOUR Frederic <frederic.hour@safran-engineering.com>,
	Huang Shijie <b32955@freescale.com>, Pekon Gupta <pekon@ti.com>,
	Brian Norris <computersforpeace@gmail.com>
Subject: [PATCH 2/2] mtd: gpmi-nand: use erased-page bitflip check
Date: Tue, 11 Mar 2014 02:11:52 -0700	[thread overview]
Message-ID: <1394529112-9659-2-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1394529112-9659-1-git-send-email-computersforpeace@gmail.com>

GPMI NAND cannot correct bitflips in unprogrammed pages.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
Untested, but perhaps this can replace the need for [1]

[1] http://lists.infradead.org/pipermail/linux-mtd/2014-January/051513.html

 drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index bb77f750e75a..f7da1d56a1b2 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -1698,6 +1698,7 @@ static int gpmi_nand_init(struct gpmi_nand_data *this)
 	chip->badblock_pattern	= &gpmi_bbt_descr;
 	chip->block_markbad	= gpmi_block_markbad;
 	chip->options		|= NAND_NO_SUBPAGE_WRITE;
+	chip->options		|= NAND_ECC_NEED_CHECK_FF;
 	if (of_get_nand_on_flash_bbt(this->dev->of_node))
 		chip->bbt_options |= NAND_BBT_USE_FLASH | NAND_BBT_NO_OOB;
 
-- 
1.8.3.2

  reply	other threads:[~2014-03-11  9:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11  9:11 [PATCH 1/2] mtd: nand: add erased-page bitflip correction Brian Norris
2014-03-11  9:11 ` Brian Norris [this message]
2014-03-11 10:12 ` Gupta, Pekon
2014-03-12  5:32   ` Brian Norris
2014-03-12  5:59     ` Elie De Brauwer
2014-03-12  6:59       ` Brian Norris
2014-03-12 12:45         ` Elie De Brauwer
2014-03-13  5:22           ` Brian Norris
2014-03-13  5:55             ` Gupta, Pekon
2014-03-13  6:28               ` Brian Norris
2014-03-13  7:01                 ` Gupta, Pekon
2014-03-17 18:47                   ` Brian Norris
2014-03-18  7:55                     ` Ricard Wanderlof
2014-03-13 12:57                 ` Ezequiel Garcia
2014-03-17 18:53                   ` Brian Norris
2014-03-13  7:37             ` Elie De Brauwer
2014-03-12  8:06 ` Huang Shijie
2014-03-13  4:55   ` Brian Norris
2014-03-13  8:04     ` Huang Shijie
2014-03-17 16:46       ` Brian Norris
2014-03-17 17:50         ` Gupta, Pekon
2014-03-18  6:48         ` Huang Shijie
2014-03-13 21:32 ` Bill Pringlemeir
2014-03-17 19:46   ` Brian Norris
2014-03-17 22:55     ` Bill Pringlemeir
2014-03-17 23:01       ` Bill Pringlemeir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394529112-9659-2-git-send-email-computersforpeace@gmail.com \
    --to=computersforpeace@gmail.com \
    --cc=b32955@freescale.com \
    --cc=dedekind1@gmail.com \
    --cc=eliedebrauwer@gmail.com \
    --cc=frederic.hour@safran-engineering.com \
    --cc=kent.li@radisys.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=pekon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.