From: Dario Faggioli <dario.faggioli@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2] tools/mfndump: Avoid unintentional NULL dereference
Date: Thu, 13 Mar 2014 13:53:52 +0100 [thread overview]
Message-ID: <1394715232.4159.4.camel@Solace> (raw)
In-Reply-To: <1394708947-29113-1-git-send-email-andrew.cooper3@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1072 bytes --]
On gio, 2014-03-13 at 11:09 +0000, Andrew Cooper wrote:
> If we failed to open an xc interface, using xch to log an error will end in
> tears. Print to stderr instead, as we are bailing immediately later.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Coverity-id: 1191885
> Acked-by: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Dario Faggioli <dario.faggioli@citrix.com>
>
If this is not yet in, feel free to add:
Acked-by: Dario Faggioli <dario.faggioli@citrix.com>
Because, I confirm, I did unintentionally and not deliberately! :-P
> v2: Reword subject
>
> This is why macros depending on variables in scope, particularly ones named
> as simily as "ERROR", are evil.
>
I Could not agree more!
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-03-13 12:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 21:04 [PATCH] tools/mfndump: Avoid deliberate NULL dereference Andrew Cooper
2014-03-13 11:06 ` Ian Campbell
2014-03-13 11:09 ` [PATCH v2] tools/mfndump: Avoid unintentional " Andrew Cooper
2014-03-13 12:53 ` Dario Faggioli [this message]
2014-03-13 18:04 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394715232.4159.4.camel@Solace \
--to=dario.faggioli@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.