From: Peter Hurley <peter@hurleysoftware.com>
To: Marcel Holtmann <marcel@holtmann.org>,
Scott James Remnant <keybuk@chromium.org>
Cc: linux-bluetooth@vger.kernel.org, Peter Hurley <peter@hurleysoftware.com>
Subject: [PATCH 0/3] Fix RFCOMM connect/disconn races
Date: Thu, 13 Mar 2014 12:43:03 -0400 [thread overview]
Message-ID: <1394728986-5096-1-git-send-email-peter@hurleysoftware.com> (raw)
In-Reply-To: <15A2D205-97BC-4790-A998-52AD8941DB3F@holtmann.org>
Marcel,
This patch series fixes the observed errors when running
rctest -r on one station and rctest -c on the other.
Please note that patch 2/3 is somewhat risky in that it allows
multiple RFCOMM sessions between the same endpoints to co-exist,
provided that all but one of the sessions is closing or is closed.
I did test this, but there may be some subtlety I've overlooked.
[I note this because you may prefer the simpler and more bulletproof
solution of returning -EBUSY from __rfcomm_dlc_open() in this
situation; I can understand if you have lost patience for RFCOMM
breakage.]
This series does not address the excessive latency from sending
the DISC command to receiving the UA reply. I think a partial
solution would be to skip the rfcomm thread and run
rfcomm_process_sessions() directly from rfcomm_l2data_ready();
this would require some rework where sk->sk_data_ready() is
called directly from contexts that aren't suitable for running
rfcomm_process_sessions(). And this wouldn't address the
USB polling latency at all.
Regards,
Peter Hurley (3):
bluetooth: rfcomm: Reply with DM after dlc disconnect
bluetooth: rfcomm: Create new session if closing old session
bluetooth: rfcomm: Defer session teardown after last dlc
net/bluetooth/rfcomm/core.c | 32 ++++++++++++++++++++++----------
1 file changed, 22 insertions(+), 10 deletions(-)
--
1.8.1.2
next prev parent reply other threads:[~2014-03-13 16:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 21:44 rctest -c "Can't connect: Device or resource busy (16)" Scott James Remnant
2014-03-11 23:03 ` Marcel Holtmann
2014-03-11 23:37 ` Scott James Remnant
2014-03-12 2:14 ` Marcel Holtmann
2014-03-12 3:01 ` Peter Hurley
2014-03-12 3:27 ` Peter Hurley
2014-03-12 4:27 ` Peter Hurley
2014-03-12 17:18 ` Peter Hurley
2014-03-28 17:49 ` Scott James Remnant
2014-03-13 16:43 ` Peter Hurley [this message]
2014-03-13 16:43 ` [PATCH 1/3] bluetooth: rfcomm: Reply with DM after dlc disconnect Peter Hurley
2014-03-13 16:43 ` [PATCH 2/3] bluetooth: rfcomm: Create new session if closing old session Peter Hurley
2014-03-13 16:43 ` [PATCH 3/3] bluetooth: rfcomm: Defer session teardown after last dlc Peter Hurley
2014-04-02 20:04 ` [PATCH 0/3] Fix RFCOMM connect/disconn races Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394728986-5096-1-git-send-email-peter@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=keybuk@chromium.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.