All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alexander Shiyan" <shc_work@mail.ru>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7][ 3/5] video: mx3fb: Introduce  =?UTF-8?B?cmVndWxhdG9yIHN1c
Date: Fri, 14 Mar 2014 12:38:35 +0000	[thread overview]
Message-ID: <1394800715.9118331@f120.i.mail.ru> (raw)
In-Reply-To: <5322E6AA.1010400@eukrea.com>

0J/Rj9GC0L3QuNGG0LAsIDE0INC80LDRgNGC0LAgMjAxNCwgMTI6MjMgKzAxOjAwINC+0YIgRGVu
aXMgQ2FyaWtsaSA8ZGVuaXNAZXVrcmVhLmNvbT46CgpTYXNjaGEsIFNoYXduLCBjYW4geW91IGNv
bW1lbnQgb24gdGhhdD8KCj4gT24gMDMvMTQvMjAxNCAxMDoyMyBBTSwgQWxleGFuZGVyIFNoaXlh
biB3cm90ZToKPiA+IFdoeSB0aGlzIGNhbm5vdCBiZSBkZXZtX3JlZ3VsYXRvcl9nZXQoZGV2LCAi
bGNkIikgaW4gYm90aCBEVCBhbmQgbm9uLURUIGNhc2U/Cj4gCj4gSSBuZWVkIHRvIGFkZCBkZXZp
Y2UgdHJlZSBzdXBwb3J0IHRvIHRoZSBteDNmYiBkcml2ZXIuCj4gTXkgZmlyc3QgYXBwcm9hY2gg
Z2F2ZSBhIGJpbmRpbmcgdGhhdCBsb29rZWQgbGlrZSB0aGF0Ogo+IAo+IGNtb19xdmdhOiBkaXNw
bGF5IHsKPiAgICBtb2RlbCA9ICJDTU8tUVZHQSI7Cj4gICAgWy4uLl0KPiAgICBkaXNwbGF5LXRp
bWluZ3Mgewo+ICAgICAgcXZnYV90aW1pbmdzOiAzMjB4MjQwIHsKPiAgICAgICAgaGFjdGl2ZSA9
IDwzMjA+Owo+ICAgICAgICB2YWN0aXZlID0gPDI0MD47Cj4gICAgICAgIFsuLi5dCj4gICAgIH07
Cj4gfTsKPiAKPiBpcHU6IGlwdUA1M2ZjMDAwMCB7Cj4gICAgY29tcGF0aWJsZSA9ICJmc2wsaW14
MzEtaXB1IjsKPiAgICByZWcgPSA8IDB4NTNmYzAwMDAgMHg1Zgo+ICAgIDB4NTNmYzAwODggMHgy
YiA+Owo+ICAgIGludGVycnVwdHMgPSA8NDIgNDE+Owo+ICAgIGRtYS1jaGFubmVscyA9IDwzMj47
Cj4gICAgI2RtYS1jZWxscyA9IDwxPjsKPiAgICBjbG9ja3MgPSA8JmNsa3MgNTU+Owo+ICAgIGNs
b2NrLW5hbWVzID0gIiI7Cj4gfTsKPiAKPiBsY2RjOiBteDNmYkA1M2ZjMDBiNCB7Cj4gICAgY29t
cGF0aWJsZSA9ICJmc2wsbXgzLWZiIjsKPiAgICByZWcgPSA8MHg1M2ZjMDBiNCAweDBiPjsKPiAg
ICBjbG9ja3MgPSA8JmNsa3MgNTU+Owo+ICAgIGRtYXMgPSA8JmlwdSAxND47Cj4gICAgZG1hLW5h
bWVzID0gInR4IjsKPiAgICBkaXNwbGF5ID0gPCZjbW9fcXZnYT47Cj4gfTsKPiAKPiBUaGUgaXNz
dWUgd2FzIHRoYXQgZXhwb3J0aW5nIHRoZSAiZG1hIGlwdSBkcml2ZXIiIHdhcyBub3QgYSBnb29k
IGlkZWEuCj4gSSB3YXMgdG9sZCB0byBpbnN0ZWFkIG1ha2UgYmluZGluZ3MgdGhhdCBsb29rcyB2
ZXJ5IHNpbWlsYXIgdG8gdGhlIGlwdXYzIAo+IGRyaXZlclsxXQo+IFNvIGF0IHRoZSBlbmQgdGhh
dCBnYXZlIHNvbWV0aGluZyBsaWtlIHRoYXQ6Cj4gCj4gY21vX3F2Z2E6IGRpc3BsYXlAZGkwIHsK
PiAgICBjb21wYXRpYmxlID0gImZzbCxteDMtcGFyYWxsZWwtZGlzcGxheSI7Cj4gICAgcmVndWxh
dG9yLW5hbWUgPSAibGNkIjsKPiAgICBsY2Qtc3VwcGx5ID0gPCZyZWdfbGNkXzN2Mz47Cj4gICAg
bW9kZWwgPSAiQ01PLVFWR0EiOwo+ICAgIGRpc3BsYXktdGltaW5ncyB7Cj4gICAgICBxdmdhX3Rp
bWluZ3M6IDMyMHgyNDAgewo+ICAgICAgICBoYWN0aXZlID0gPDMyMD47Cj4gICAgICAgIHZhY3Rp
dmUgPSA8MjQwPjsKPiAgICAgICAgWy4uLl0KPiAgICAgfTsKPiB9Owo+IAo+IGlwdTogaXB1QDUz
ZmMwMDAwIHsKPiAgICBjb21wYXRpYmxlID0gImZzbCxpbXgzNS1pcHUiOwo+ICAgIHJlZyA9IDww
eDUzZmMwMDAwIDB4NDAwMD47Cj4gICAgY2xvY2tzID0gPCZjbGtzIDU1PjsKPiAgICBkaXNwbGF5
ID0gPCZjbW9fcXZnYT47Cj4gfTsKPiAKPiBTbyBoZXJlIGZzbCxpbXgzNS1pcHUgaXMgYmluZGVk
IHRvIHRoZSBteDNmYiBkcml2ZXIuCj4gQnV0IHRoZSBteDNmYiBkcml2ZXIgc3RpbGwgbmVlZCB0
byB1c2UgdGhlIGRtYS1pcHUgZHJpdmVyIHNvbWVob3cuCj4gVGhhdCdzIHdoeSB0aGUgZG1hLWlw
dSBkcml2ZXIgaXMgaGFuZGxlZCBiZWhpbmQgdGhlIHNjZW5lcywgdGhhdCB3YXkKPiBpdCdzIG5v
dCBleHBvcnRlZCB0byB0aGUgZGV2aWNlIHRyZWUgYmluZGluZ3MuCj4gCj4gTm93LCBzaW5jZSB0
aGUgbXgzZmIgZHJpdmVyIGlzIGJpbmRlZCB0byB0aGUgImZzbCxpbXgzNS1pcHUiIGNvbXBhdGli
bGUsCj4gaWYgSSB3b3VsZCBkbyBhICJteDNmYmktPnJlZ19sY2QgPSBkZXZtX3JlZ3VsYXRvcl9n
ZXQoZGV2LCAibGNkIik7IiwKPiB0aGF0IHdvdWxkIHRoZW4gbG9va3VwIGZvciB0aGUgcmVndWxh
dG9yIGluIHRoZSBteDNmYiBub2RlCj4gKFRoZSBsYXN0ICJpcHVANTNmYzAwMDAiIGhlcmUpLgo+
IAo+IEluc3RlYWQgdGhlIHJlZ3VsYXRvciBjYW4gYmUgZm91bmQgaW4gdGhlIGRpc3BsYXkgbm9k
ZSwKPiB3aGljaCBoYXMgbm8gZHJpdmVyIGFzc29jaWF0ZWQgd2l0aCBpdC4KPiAKPiBJbiB0aGUg
Y2FzZSBvZiB0aGUgaXB1djMsIHRoZSBwYXJhbGxlbCBkaXNwbGF5IGRyaXZlciBpcyBhc3NvY2lh
dGVkCj4gd2l0aCB0aGUgZGlzcGxheUBkaTAgbm9kZSwgc28gdGhlIGRldmljZSBtYXRjaGVzIHdp
dGggdGhlIGRldmljZSB0cmVlCj4gbm9kZSBkaXJlY3RseS4KPiAKPiBSZWZlcmVuY2VzOgo+IC0t
LS0tLS0tLS0tCj4gWzFdIFRoZSBpcHV2MyBkcml2ZXIgaXMgaW4gZHJpdmVycy9zdGFnaW5nL2lt
eC1kcm0vCj4gWzJdIHRoZSBkbWEgaXB1IGRyaXZlciBpcyBpbiBkcml2ZXJzL2RtYS9pcHUvCj4g
CgotLS0K

WARNING: multiple messages have this Message-ID (diff)
From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7][ 3/5] video: mx3fb: Introduce regulator support.
Date: Fri, 14 Mar 2014 16:38:35 +0400	[thread overview]
Message-ID: <1394800715.9118331@f120.i.mail.ru> (raw)
In-Reply-To: <5322E6AA.1010400@eukrea.com>

???????, 14 ????? 2014, 12:23 +01:00 ?? Denis Carikli <denis@eukrea.com>:

Sascha, Shawn, can you comment on that?

> On 03/14/2014 10:23 AM, Alexander Shiyan wrote:
> > Why this cannot be devm_regulator_get(dev, "lcd") in both DT and non-DT case?
> 
> I need to add device tree support to the mx3fb driver.
> My first approach gave a binding that looked like that:
> 
> cmo_qvga: display {
>    model = "CMO-QVGA";
>    [...]
>    display-timings {
>      qvga_timings: 320x240 {
>        hactive = <320>;
>        vactive = <240>;
>        [...]
>     };
> };
> 
> ipu: ipu at 53fc0000 {
>    compatible = "fsl,imx31-ipu";
>    reg = < 0x53fc0000 0x5f
>    0x53fc0088 0x2b >;
>    interrupts = <42 41>;
>    dma-channels = <32>;
>    #dma-cells = <1>;
>    clocks = <&clks 55>;
>    clock-names = "";
> };
> 
> lcdc: mx3fb at 53fc00b4 {
>    compatible = "fsl,mx3-fb";
>    reg = <0x53fc00b4 0x0b>;
>    clocks = <&clks 55>;
>    dmas = <&ipu 14>;
>    dma-names = "tx";
>    display = <&cmo_qvga>;
> };
> 
> The issue was that exporting the "dma ipu driver" was not a good idea.
> I was told to instead make bindings that looks very similar to the ipuv3 
> driver[1]
> So at the end that gave something like that:
> 
> cmo_qvga: display at di0 {
>    compatible = "fsl,mx3-parallel-display";
>    regulator-name = "lcd";
>    lcd-supply = <&reg_lcd_3v3>;
>    model = "CMO-QVGA";
>    display-timings {
>      qvga_timings: 320x240 {
>        hactive = <320>;
>        vactive = <240>;
>        [...]
>     };
> };
> 
> ipu: ipu at 53fc0000 {
>    compatible = "fsl,imx35-ipu";
>    reg = <0x53fc0000 0x4000>;
>    clocks = <&clks 55>;
>    display = <&cmo_qvga>;
> };
> 
> So here fsl,imx35-ipu is binded to the mx3fb driver.
> But the mx3fb driver still need to use the dma-ipu driver somehow.
> That's why the dma-ipu driver is handled behind the scenes, that way
> it's not exported to the device tree bindings.
> 
> Now, since the mx3fb driver is binded to the "fsl,imx35-ipu" compatible,
> if I would do a "mx3fbi->reg_lcd = devm_regulator_get(dev, "lcd");",
> that would then lookup for the regulator in the mx3fb node
> (The last "ipu at 53fc0000" here).
> 
> Instead the regulator can be found in the display node,
> which has no driver associated with it.
> 
> In the case of the ipuv3, the parallel display driver is associated
> with the display at di0 node, so the device matches with the device tree
> node directly.
> 
> References:
> -----------
> [1] The ipuv3 driver is in drivers/staging/imx-drm/
> [2] the dma ipu driver is in drivers/dma/ipu/
> 

---

  reply	other threads:[~2014-03-14 12:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14  9:12 [PATCH v7][ 1/5] video: mx3fb: Use devm_kzalloc Denis Carikli
2014-03-14  9:12 ` Denis Carikli
2014-03-14  9:12 ` [PATCH v7][ 2/5] video: mx3fb: Add device tree suport Denis Carikli
2014-03-14  9:12   ` Denis Carikli
2014-03-14  9:12 ` [PATCH v7][ 3/5] video: mx3fb: Introduce regulator support Denis Carikli
2014-03-14  9:12   ` Denis Carikli
2014-03-14  9:23   ` [PATCH v7][ 3/5] video: mx3fb: Introduce =?UTF-8?B?cmVndWxhdG9yIHN1c Alexander Shiyan
2014-03-14  9:23     ` [PATCH v7][ 3/5] video: mx3fb: Introduce regulator support Alexander Shiyan
2014-03-14 11:23     ` Denis Carikli
2014-03-14 11:23       ` Denis Carikli
2014-03-14 12:38       ` Alexander Shiyan [this message]
2014-03-14 12:38         ` Alexander Shiyan
2014-03-17  6:20   ` Sascha Hauer
2014-03-17  6:20     ` Sascha Hauer
2014-06-10 13:29     ` Denis Carikli
2014-06-10 13:29       ` Denis Carikli
2014-08-22 22:00       ` Mark Brown
2014-08-22 22:00         ` Mark Brown
2014-06-19  6:58   ` Denis Carikli
2014-06-19  6:58     ` Denis Carikli
2014-03-14  9:12 ` [PATCH v7][ 4/5] ARM: dts: i.MX35: Add display support Denis Carikli
2014-03-14  9:12   ` Denis Carikli
2014-03-14  9:12 ` =?UTF-8?q?=5BPATCH=20v7=5D=5B=205/5=5D=20ARM=3A=20dts=3A=20mbimxsd35=20Add=20video=20and=20displays= Denis Carikli
2014-03-14  9:12   ` [PATCH v7][ 5/5] ARM: dts: mbimxsd35 Add video and displays support Denis Carikli
2014-05-08 10:31 ` [PATCH v7][ 1/5] video: mx3fb: Use devm_kzalloc Tomi Valkeinen
2014-05-08 10:31   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394800715.9118331@f120.i.mail.ru \
    --to=shc_work@mail.ru \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.