From: Ralph Mueck <linux-kernel@rmueck.de>
To: linux-kernel@rmueck.de
Cc: i4passt@lists.cs.fau.de, neilb@suse.de,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthias Oefelein <ma.oefelein@arcor.de>
Subject: [PATCH 1/2] md: Add configurability for consistency check feature
Date: Mon, 17 Mar 2014 16:00:04 +0100 [thread overview]
Message-ID: <1395068405-13860-2-git-send-email-linux-kernel@rmueck.de> (raw)
In-Reply-To: <1395068405-13860-1-git-send-email-linux-kernel@rmueck.de>
This patch adds sysfs configurability for the md level-1 RAID
consistency check.
The feature introduces a new attribute in sysfs named "safe_read".
To toggle consistency checks on/off, simply echo safe_read in
/sys/block/md*/md/safe_read.
Signed-off-by: Ralph Mueck <linux-kernel@rmueck.de>
Signed-off-by: Matthias Oefelein <ma.oefelein@arcor.de>
---
drivers/md/md.c | 27 +++++++++++++++++++++++++++
drivers/md/md.h | 3 +++
2 files changed, 30 insertions(+)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 4ad5cc4..5cc9a00 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -4652,6 +4652,32 @@ static struct md_sysfs_entry md_array_size =
__ATTR(array_size, S_IRUGO|S_IWUSR, array_size_show,
array_size_store);
+static ssize_t
+safe_read_show(struct mddev *mddev, char *page)
+{
+ if(mddev->safe_read)
+ return sprintf(page, "enabled\n");
+ else
+ return sprintf(page, "disabled\n");
+}
+
+static ssize_t
+safe_read_store(struct mddev *mddev, const char *buf, size_t len)
+{
+ if(mddev->pers->level != 1) {
+ printk(KERN_NOTICE "RAID level not supported!\n");
+ return len;
+ }
+ if (strncmp(buf, "safe_read", 9) == 0) {
+ mddev->safe_read = !mddev->safe_read;
+ }
+ return len;
+}
+
+static struct md_sysfs_entry md_safe_read =
+__ATTR(safe_read, S_IRUGO|S_IWUSR, safe_read_show,
+ safe_read_store);
+
static struct attribute *md_default_attrs[] = {
&md_level.attr,
&md_layout.attr,
@@ -4667,6 +4693,7 @@ static struct attribute *md_default_attrs[] = {
&md_reshape_direction.attr,
&md_array_size.attr,
&max_corr_read_errors.attr,
+ &md_safe_read.attr,
NULL,
};
diff --git a/drivers/md/md.h b/drivers/md/md.h
index 07bba96..7e59cf1 100644
--- a/drivers/md/md.h
+++ b/drivers/md/md.h
@@ -346,6 +346,9 @@ struct mddev {
*/
int recovery_disabled;
+ /* Set to 1 if the user desires a safe read (check for bitrot) */
+ int safe_read;
+
int in_sync; /* know to not need resync */
/* 'open_mutex' avoids races between 'md_open' and 'do_md_stop', so
* that we are never stopping an array while it is open.
--
1.8.3.2
next prev parent reply other threads:[~2014-03-17 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 15:00 [PATCH 0/2] md: Add consistency check feature for level-1 RAID Ralph Mueck
2014-03-17 15:00 ` Ralph Mueck [this message]
2014-03-17 22:54 ` [PATCH 1/2] md: Add configurability for consistency check feature NeilBrown
2014-03-17 15:00 ` [PATCH 2/2] md: Add support for RAID-1 " Ralph Mueck
2014-03-17 23:09 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395068405-13860-2-git-send-email-linux-kernel@rmueck.de \
--to=linux-kernel@rmueck.de \
--cc=i4passt@lists.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=ma.oefelein@arcor.de \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.