From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [RFC Patch 3/3] Fix formatting and misleading comments/variables in sedf Date: Mon, 17 Mar 2014 17:49:52 +0100 Message-ID: <1395074992.4159.305.camel@Solace> References: <1394824400-2796-1-git-send-email-nate.studer@dornerworks.com> <1394824400-2796-4-git-send-email-nate.studer@dornerworks.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5951147720282133871==" Return-path: In-Reply-To: <1394824400-2796-4-git-send-email-nate.studer@dornerworks.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Nathan Studer Cc: Ian Campbell , Xi Sisu , Stefano Stabellini , George Dunlap , Ian Jackson , Robert VanVossen , xen-devel@lists.xen.org, Joshua Whitehead , Dario Faggioli List-Id: xen-devel@lists.xenproject.org --===============5951147720282133871== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-xGjCj+TgmwEqoDWFH+a0" --=-xGjCj+TgmwEqoDWFH+a0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On ven, 2014-03-14 at 15:13 -0400, Nathan Studer wrote: > From: Nathan Studer >=20 > Update the sedf scheduler to correct some of the more aggregious formatti= ng > issues. Also update some of the misleading comments/variable names. > Specifically the sedf scheduler still implies that a domain and a vcpu > are the same thing, which while true in the past is no longer the case. >=20 > Signed-off-by: Nathan Studer > Signed-off-by: Joshua Whitehead > Both this and the previous patch looks fine, and, as said replying to the cover letter, are something I think we want. I'd provide a formal Reviewed-by tag, but I guess it's not that important, as this is an RFC.... I'll do as soon as a non-RFC series will pop up. One question, on what is this based? I tried to apply the series on today's tip, and it fails :-/ This is what I get trying to apply the first patch: checking file xen/common/sched_sedf.c Hunk #1 FAILED at 25. Hunk #2 succeeded at 58 (offset -3 lines). Hunk #3 succeeded at 73 (offset -3 lines). Hunk #4 succeeded at 94 (offset -3 lines). Hunk #5 succeeded at 179 (offset -3 lines). Hunk #6 FAILED at 199. Hunk #7 succeeded at 205 with fuzz 2 (offset -12 lines). Hunk #8 succeeded at 221 (offset -12 lines). Hunk #9 succeeded at 303 (offset -12 lines). Hunk #10 succeeded at 313 (offset -12 lines). Hunk #11 succeeded at 402 (offset -12 lines). Hunk #12 succeeded at 441 (offset -12 lines). Hunk #13 succeeded at 461 (offset -12 lines). Hunk #14 succeeded at 503 (offset -12 lines). Hunk #15 succeeded at 513 (offset -12 lines). Hunk #16 succeeded at 525 (offset -12 lines). Hunk #17 succeeded at 540 (offset -12 lines). Hunk #18 succeeded at 575 (offset -12 lines). Hunk #19 succeeded at 600 (offset -12 lines). Hunk #20 succeeded at 609 (offset -12 lines). Hunk #21 succeeded at 627 (offset -12 lines). Hunk #22 succeeded at 641 (offset -12 lines). Hunk #23 succeeded at 667 (offset -12 lines). Hunk #24 succeeded at 678 (offset -12 lines). Hunk #25 succeeded at 710 (offset -12 lines). Hunk #26 succeeded at 730 (offset -12 lines). Hunk #27 succeeded at 781 (offset -12 lines). Hunk #28 succeeded at 894 (offset 69 lines). Hunk #29 FAILED at 842. Hunk #30 FAILED at 859. 4 out of 30 hunks FAILED Can you provide an updated version? Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-xGjCj+TgmwEqoDWFH+a0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlMnJ7AACgkQk4XaBE3IOsSLhACfXfFqVvgcr6r2BnUEMvf2pt1e 6qkAn2nG1hNkvnKgLvaZpoYF883w/6bA =wpE/ -----END PGP SIGNATURE----- --=-xGjCj+TgmwEqoDWFH+a0-- --===============5951147720282133871== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5951147720282133871==--