All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Stanacar, StefanX" <stefanx.stanacar@intel.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] testimage: dont use DNS lookup for qemu based testimages
Date: Wed, 19 Mar 2014 21:44:37 +0000	[thread overview]
Message-ID: <1395265477.3808.140.camel@ted> (raw)
In-Reply-To: <1395231830.31252.10.camel@firebird.rb.intel.com>

On Wed, 2014-03-19 at 12:23 +0000, Stanacar, StefanX wrote:
> 
> 
> On Tue, 2014-03-18 at 17:31 -0700, Saul Wold wrote:
> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
> > ---
> >  meta/classes/testimage.bbclass | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/meta/classes/testimage.bbclass b/meta/classes/testimage.bbclass
> > index 691c7f6..ee028e1 100644
> > --- a/meta/classes/testimage.bbclass
> > +++ b/meta/classes/testimage.bbclass
> > @@ -45,6 +45,16 @@ TESTIMAGEDEPENDS_qemuall = "qemu-native:do_populate_sysroot qemu-helper-native:d
> >  TESTIMAGELOCK = "${TMPDIR}/testimage.lock"
> >  TESTIMAGELOCK_qemuall = ""
> >  
> > +IMAGE_POSTPROCESS_COMMAND_qemuall += "fix_dns_lookup_for_qemu"
> > +
> 
> I might be wrong, but this won't have any effect with the default
> (manual) way we use testimage. The testimage class isn't in the global
> inherit, so that  IMAGE_POSTPROCESS_COMMAND won't run as the image isn't
> reconstructed.

Surely it will have run when the rootfs was originally constructed
though?

Koen is right, that override is incorrect.

Cheers,

Richard



      parent reply	other threads:[~2014-03-19 21:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19  0:31 [PATCH v2] testimage: dont use DNS lookup for qemu based testimages Saul Wold
2014-03-19 11:20 ` Koen Kooi
2014-03-19 12:23 ` Stanacar, StefanX
2014-03-19 13:17   ` Paul Eggleton
2014-03-19 20:06     ` Saul Wold
2014-03-19 21:43       ` Flanagan, Elizabeth
2014-03-19 22:57       ` Paul Eggleton
2014-03-19 21:44   ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395265477.3808.140.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=stefanx.stanacar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.