From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: OpenEmbedded Core Mailing List
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] packagegroup-core-tools-testapps: Move GLTOOLS to X11GLTOOLS
Date: Sun, 30 Mar 2014 10:14:22 +0100 [thread overview]
Message-ID: <1396170862.14790.33.camel@ted> (raw)
In-Reply-To: <1396123481-6064-1-git-send-email-otavio@ossystems.com.br>
On Sat, 2014-03-29 at 17:04 -0300, Otavio Salvador wrote:
> piglit and mesa-demos are not buildable in x11-less distros so we must
> to add those only when opengl and x11 DISTRO_FEATURES are available.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> meta/recipes-core/packagegroups/packagegroup-core-tools-testapps.bb | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-testapps.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-testapps.bb
> index d8a7306..0ced119 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-core-tools-testapps.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-testapps.bb
> @@ -24,7 +24,7 @@ KEXECTOOLS_powerpc ?= ""
> KEXECTOOLS_e5500-64b ?= ""
> KEXECTOOLS_aarch64 ?= ""
>
> -GLTOOLS = "\
> +X11GLTOOLS = "\
> mesa-demos \
> piglit \
> "
> @@ -58,6 +58,7 @@ RDEPENDS_${PN} = "\
> connman-tests \
> connman-client \
> ${@base_contains('DISTRO_FEATURES', 'x11', "${X11TOOLS}", "", d)} \
> - ${@base_contains('DISTRO_FEATURES', 'opengl', "${GLTOOLS}", "", d)} \
> + ${@base_contains('DISTRO_FEATURES', 'opengl', \
> + base_contains('DISTRO_FEATURES', 'x11', "${X11GLTOOLS}", "", d), "", d)} \
Please just do:
base_contains('DISTRO_FEATURES', 'x11 opengl', "${X11GLTOOLS}", "", d)}
Cheers,
Richard
next prev parent reply other threads:[~2014-03-30 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-29 20:04 [PATCH v2] packagegroup-core-tools-testapps: Move GLTOOLS to X11GLTOOLS Otavio Salvador
2014-03-30 9:14 ` Richard Purdie [this message]
2014-03-31 10:14 ` Burton, Ross
2014-03-31 13:47 ` Otavio Salvador
2014-03-31 13:54 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396170862.14790.33.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.