All of lore.kernel.org
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@ingics.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Matt Porter <mporter@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] mfd: bcm590xx: Add missing remove function
Date: Mon, 31 Mar 2014 21:32:37 +0800	[thread overview]
Message-ID: <1396272757.7843.2.camel@phoenix> (raw)
In-Reply-To: <1396272676.7843.1.camel@phoenix>

Add missing mfd_remove_devices() call in remove function.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/mfd/bcm590xx.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
index 40c0dd3..c986149 100644
--- a/drivers/mfd/bcm590xx.c
+++ b/drivers/mfd/bcm590xx.c
@@ -64,6 +64,12 @@ static int bcm590xx_i2c_probe(struct i2c_client *i2c,
 	return ret;
 }
 
+static int bcm590xx_i2c_remove(struct i2c_client *i2c)
+{
+	mfd_remove_devices(&i2c->dev);
+	return 0;
+}
+
 static const struct of_device_id bcm590xx_of_match[] = {
 	{ .compatible = "brcm,bcm59056" },
 	{ }
@@ -83,6 +89,7 @@ static struct i2c_driver bcm590xx_i2c_driver = {
 		   .of_match_table = of_match_ptr(bcm590xx_of_match),
 	},
 	.probe = bcm590xx_i2c_probe,
+	.remove = bcm590xx_i2c_remove,
 	.id_table = bcm590xx_i2c_id,
 };
 module_i2c_driver(bcm590xx_i2c_driver);
-- 
1.8.3.2




  reply	other threads:[~2014-03-31 13:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31 13:31 [PATCH 1/2] mfd: bcm590xx: Fix modalias prefix Axel Lin
2014-03-31 13:32 ` Axel Lin [this message]
2014-04-15 10:03   ` [PATCH 2/2] mfd: bcm590xx: Add missing remove function Lee Jones
2014-04-15 10:03 ` [PATCH 1/2] mfd: bcm590xx: Fix modalias prefix Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396272757.7843.2.camel@phoenix \
    --to=axel.lin@ingics.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mporter@linaro.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.