Re: [PATCH] bitbake: parse: allow vars_from_file to consider inc files as recipes

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2014-03-31 at 16:44 -0400, joe@deserted.net wrote:
> From: Joe MacDonald <joe@deserted.net>
> 
> A side-effect of making vars_from_file return None for non-recipes is that
> PV gets 'None' if you have an included file named <recipe>.inc.  If there
> is a recipe with a version number in the name for a .inc file, it's
> probably reasonable to calculate PV based on that file, rather than giving
> it 'None' (which becomes 1.0 in most cases).
> 
> Signed-off-by: Joe MacDonald <joe@deserted.net>
> ---
>  bitbake/lib/bb/parse/__init__.py |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> I ran into this when building meta-selinux where there's a chain of includes:
> 
>    refpolicy-mls_2.20130424.bb
>     -> refpolicy_2.20130424.inc
>       -> refpolicy_common.inc

The question to ask here is why is PV being expanded during the .inc
file?

When this code was changed, we did find some issues like this but it
usually means something unexpected was happening and "bad" PV values
were actually being used in some cases. It was therefore a conscious
decision not to do this.

If I take this change, you could get PV of "common" being used in the
second .inc file which is nasty.

I'd therefore much rather figure out what is happening to cause the
expansion of PV in the .inc file and see if we can't avoid that.

Looking at the layer, the issue is:

FILESEXTRAPATHS_prepend := "${THISDIR}/refpolicy-${PV}:"

and I'd suggest that line move to the .bb files in this case.

Cheers,

Richard