From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Florin Sarbu <florin.sarbu@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] connman.inc: Add PACKAGECONFIG support for bluez5
Date: Tue, 01 Apr 2014 11:51:07 +0100 [thread overview]
Message-ID: <1396349467.1432.4.camel@ted> (raw)
In-Reply-To: <1396346945-3782-1-git-send-email-florin.sarbu@windriver.com>
On Tue, 2014-04-01 at 13:09 +0300, Florin Sarbu wrote:
> Currently connman can only RDEPEND on bluez4.
> This patch adds support for having bluez5 in PACKAGECONFIG
> and get connman RDEPEND on bluez5 if desired.
>
> Signed-off-by: Florin Sarbu <florin.sarbu@windriver.com>
> ---
> meta/recipes-connectivity/connman/connman.inc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> index b3147c9..53a6a4f 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -32,7 +32,7 @@ EXTRA_OECONF += "\
>
> PACKAGECONFIG ??= "wispr \
> ${@base_contains('DISTRO_FEATURES', 'wifi','wifi', '', d)} \
> - ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluetooth', '', d)} \
> + ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluez4', '', d)} \
> ${@base_contains('DISTRO_FEATURES', '3g','3g', '', d)} \
> "
>
> @@ -42,6 +42,7 @@ PACKAGECONFIG ??= "wispr \
>
> PACKAGECONFIG[wifi] = "--enable-wifi, --disable-wifi, wpa-supplicant"
> PACKAGECONFIG[bluetooth] = "--enable-bluetooth, --disable-bluetooth, bluez4"
You renamed the option above but didn't here and hence broke bluez4.
This is not the quality of patch expected at -rc time for a release :(.
Cheers,
Richard
> +PACKAGECONFIG[bluez5] = "--enable-bluetooth, --disable-bluetooth, bluez5"
> PACKAGECONFIG[3g] = "--enable-ofono, --disable-ofono, ofono"
> PACKAGECONFIG[tist] = "--enable-tist,--disable-tist,"
> PACKAGECONFIG[openvpn] = "--enable-openvpn --with-openvpn=${sbindir}/openvpn,--disable-openvpn,,openvpn"
> @@ -114,6 +115,7 @@ RPROVIDES_${PN} = "\
> RDEPENDS_${PN} = "\
> dbus \
> ${@base_contains('PACKAGECONFIG', 'bluetooth', 'bluez4', '', d)} \
> + ${@base_contains('PACKAGECONFIG', 'bluez5', 'bluez5', '', d)} \
> ${@base_contains('PACKAGECONFIG', 'wifi','wpa-supplicant', '', d)} \
> ${@base_contains('PACKAGECONFIG', '3g','ofono', '', d)} \
> xuser-account \
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-04-01 10:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 10:09 [PATCH] connman.inc: Add PACKAGECONFIG support for bluez5 Florin Sarbu
2014-04-01 10:51 ` Richard Purdie [this message]
2014-04-01 11:23 ` Iorga, Cristian
2014-04-01 12:27 ` Florin Sarbu
2014-04-01 13:22 ` Iorga, Cristian
2014-04-01 13:27 ` Iorga, Cristian
2014-04-01 13:41 ` Florin Sarbu
2014-04-01 14:16 ` Burton, Ross
2014-04-01 14:24 ` Florin Sarbu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396349467.1432.4.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=florin.sarbu@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.