From: Paul Bolle <pebolle@tiscali.nl>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARC: Remove ISS_SMP_EXTN entirely
Date: Tue, 08 Apr 2014 12:42:23 +0200 [thread overview]
Message-ID: <1396953743.26620.23.camel@x220> (raw)
In-Reply-To: <C2D7FE5348E1B147BCA15975FBA230751AC602@IN01WEMBXA.internal.synopsys.com>
Vineet,
On Tue, 2014-04-08 at 09:18 +0000, Vineet Gupta wrote:
> There's obvious bitrot here - however this code is not dead yet !
> I have a unpushed fix which uses this Kconfig item.
>
> diff --git a/arch/arc/plat-arcfpga/Makefile b/arch/arc/plat-arcfpga/Makefile
> index a44e22ebc1b7..4d1bddc34b5b 100644
> --- a/arch/arc/plat-arcfpga/Makefile
> +++ b/arch/arc/plat-arcfpga/Makefile
> @@ -9,4 +9,4 @@
> KBUILD_CFLAGS += -Iarch/arc/plat-arcfpga/include
>
> obj-y := platform.o irq.o
> -obj-$(CONFIG_SMP) += smp.o
> +obj-$(CONFIG_ISS_SMP_EXTN) += smp.o
I just realized that this means you're only using ISS_SMP_EXTN as an
alias for SMP, aren't you? Ie, smp.o will now be built if both
ARC_PLAT_FPGA_LEGACY and SMP are set. That will not change by this
patch.
So unless you're planning to do something else too if ISS_SMP_EXTN is
set there seems to be little value in using this symbol like that.
Paul Bolle
next prev parent reply other threads:[~2014-04-08 10:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 8:56 [PATCH] ARC: Remove ISS_SMP_EXTN entirely Paul Bolle
2014-04-08 9:18 ` Vineet Gupta
2014-04-08 9:36 ` Paul Bolle
2014-04-08 10:42 ` Paul Bolle [this message]
2014-04-08 10:49 ` Vineet Gupta
2014-04-08 11:19 ` Vineet Gupta
2014-04-08 10:51 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396953743.26620.23.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=Vineet.Gupta1@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.