From: Archit Taneja <archit@ti.com>
To: tomi.valkeinen@ti.com, robdclark@gmail.com
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH 2/6] drm/omap: gem sync: wait on correct events
Date: Fri, 11 Apr 2014 12:53:31 +0530 [thread overview]
Message-ID: <1397201015-2807-3-git-send-email-archit@ti.com> (raw)
In-Reply-To: <1397201015-2807-1-git-send-email-archit@ti.com>
A waiter of the type OMAP_GEM_READ should wait for a buffer to be completely
written, and only then proceed with reading it. A similar logic applies for
waiters with OMAP_GEM_WRITE flag.
Currently the function is_waiting() waits on the read_complete/read_target
counts in the sync object.
This should be the other way round, as a reader should wait for users who are
'writing' to this buffer, and vice versa.
Make readers of the buffer(OMAP_GEM_READ) wait on the write counters, and
writers to the buffer(OMAP_GEM_WRITE) wait on the read counters in is_waiting()
Signed-off-by: Archit Taneja <archit@ti.com>
---
drivers/gpu/drm/omapdrm/omap_gem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
index 3199e3f..002b89d7 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.c
+++ b/drivers/gpu/drm/omapdrm/omap_gem.c
@@ -1050,10 +1050,10 @@ static inline bool is_waiting(struct omap_gem_sync_waiter *waiter)
{
struct omap_gem_object *omap_obj = waiter->omap_obj;
if ((waiter->op & OMAP_GEM_READ) &&
- (omap_obj->sync->read_complete < waiter->read_target))
+ (omap_obj->sync->write_complete < waiter->write_target))
return true;
if ((waiter->op & OMAP_GEM_WRITE) &&
- (omap_obj->sync->write_complete < waiter->write_target))
+ (omap_obj->sync->read_complete < waiter->read_target))
return true;
return false;
}
--
1.8.3.2
next prev parent reply other threads:[~2014-04-11 7:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 7:23 [PATCH 0/6] drm/omap: Misc fixes Archit Taneja
2014-04-11 7:23 ` [PATCH 1/6] drm/omap: Fix memory leak in omap_gem_op_async Archit Taneja
2014-04-11 7:23 ` Archit Taneja [this message]
2014-04-11 7:23 ` [PATCH 3/6] drm/omap: Fix crash when using LCD3 overlay manager Archit Taneja
2014-04-11 7:23 ` [PATCH 4/6] drm/omap: Allow allocation of larger buffers Archit Taneja
2014-04-14 9:25 ` Tomi Valkeinen
2014-04-14 10:18 ` Archit Taneja
2014-04-14 10:30 ` Tomi Valkeinen
2014-04-14 11:07 ` Archit Taneja
2014-04-14 10:43 ` Rob Clark
2014-04-11 7:23 ` [PATCH 5/6] drm/omap: Use old_fb to synchronize between successive page flips Archit Taneja
2014-04-11 7:23 ` [PATCH 6/6] drm/omap: protect omap_crtc's event with event_lock spinlock Archit Taneja
2014-04-14 12:36 ` Tomi Valkeinen
2014-04-16 7:06 ` Archit Taneja
2014-04-15 9:42 ` [PATCH 0/6] drm/omap: Misc fixes Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397201015-2807-3-git-send-email-archit@ti.com \
--to=archit@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=robdclark@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.