All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 0/3] drm/tegra: Use standard suffix for hotplug detect GPIO property
Date: Thu, 17 Apr 2014 19:25:54 +0200	[thread overview]
Message-ID: <1397755554.2148.3.camel@tellur> (raw)
In-Reply-To: <1397736181-1593-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Am Donnerstag, den 17.04.2014, 14:02 +0200 schrieb Thierry Reding:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> The hotplug detect GPIO in the current bindings use "-gpio" as suffix,
> whereas the standard suffix is the plural: "-gpios". This small series
> replaces this in three steps to preserve bisectability:
> 
>   - Patch 1 adds new nvidia,hpd-gpios properties to existing device tree
>     files while marking existing nvidia,hpd-gpio ones as deprecated.
>   - Patch 2 makes use of the new property name in the driver and updates
>     the device tree bindings.
>   - Patch 3 removes the deprecated properties from device tree files.
> 
> Since this touches both DRM and Tegra trees, I've prepared a stable
> branch[0] that can be pulled into both trees to make the transition
> easier.
> 
What's the real benefit to this series? After all you are breaking
existing devicetrees here, as the driver doesn't continue to recognize
the old name. IMHO adding a missed 's' to the property name isn't enough
reason to do this.

Regards,
Lucas

  parent reply	other threads:[~2014-04-17 17:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-17 12:02 [PATCH 0/3] drm/tegra: Use standard suffix for hotplug detect GPIO property Thierry Reding
2014-04-17 12:02 ` [PATCH 1/3] ARM: tegra: Deprecate nvidia,hpd-gpio property Thierry Reding
     [not found]   ` <1397736181-1593-2-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-04-21 19:43     ` Stephen Warren
     [not found]       ` <535574D6.3010002-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-04-22  7:23         ` Thierry Reding
2014-04-22 15:57           ` Lucas Stach
2014-04-17 12:03 ` [PATCH 2/3] drm/tegra: Use nvidia,hpd-gpios property Thierry Reding
     [not found] ` <1397736181-1593-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-04-17 12:03   ` [PATCH 3/3] ARM: tegra: Remove deprecated nvidia,hpd-gpio properties Thierry Reding
2014-04-17 17:25   ` Lucas Stach [this message]
2014-04-17 21:28     ` [PATCH 0/3] drm/tegra: Use standard suffix for hotplug detect GPIO property Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397755554.2148.3.camel@tellur \
    --to=dev-8ppwabl0hbeelga04laivw@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.