From: Masanari Iida <standby24x7@gmail.com>
To: a.p.zijlstra@chello.nl, jolsa@redhat.com, paulus@samba.org,
mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org
Cc: Masanari Iida <standby24x7@gmail.com>
Subject: [PATCH] perf test x86: Fit memory leak in sample_ustack()
Date: Sun, 20 Apr 2014 00:16:41 +0900 [thread overview]
Message-ID: <1397920601-27712-1-git-send-email-standby24x7@gmail.com> (raw)
buf is not freed, when kernel failed to get stack map
and return.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
tools/perf/arch/x86/tests/dwarf-unwind.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/arch/x86/tests/dwarf-unwind.c b/tools/perf/arch/x86/tests/dwarf-unwind.c
index b602ad9..68f2711 100644
--- a/tools/perf/arch/x86/tests/dwarf-unwind.c
+++ b/tools/perf/arch/x86/tests/dwarf-unwind.c
@@ -26,6 +26,7 @@ static int sample_ustack(struct perf_sample *sample,
map = map_groups__find(&thread->mg, MAP__FUNCTION, (u64) sp);
if (!map) {
pr_debug("failed to get stack map\n");
+ kfree(buf);
return -1;
}
--
1.9.2.468.g3f0c02a
next reply other threads:[~2014-04-19 15:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 15:16 Masanari Iida [this message]
2014-04-19 22:19 ` [PATCH] perf test x86: Fit memory leak in sample_ustack() Jiri Olsa
2014-04-19 22:33 ` Jiri Olsa
2014-04-21 14:37 ` [PATCH/v2] " Masanari Iida
2014-04-23 13:13 ` [tip:perf/urgent] perf tests x86: Fix " tip-bot for Masanari Iida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397920601-27712-1-git-send-email-standby24x7@gmail.com \
--to=standby24x7@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.