From: Dominique van den Broeck <domdevlin@free.fr>
To: Levente Kurusa <levex@linux.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging/rtl8192e: userspace ptr deref + incorrect declarations
Date: Sun, 27 Apr 2014 20:05:18 +0200 [thread overview]
Message-ID: <1398621918.30622.6.camel@wisdom> (raw)
In-Reply-To: <20140427174753.GA25594@linux.com>
Hello,
Thanks for your comments and reviewing.
> I guess it would be better to have defines for those instead of
> hard-coding the offsets. Also the size of the info_buf array
> might change depending on the size of wrqu->data.pointer, right?
> Maybe create a new define for that as well?
> Let's just be safe and create new defines to prevent headaches in
> the future, if not for futher expansion then for the sake of
> legibility.
As regards those hardcoded indexes, I totally agree.
Still, for this particular patch only, I tried to stick to what
was signaled by sparse. I kept the rest as it was. "info_buf",
directly pointing userspace, and its index numbers are declared
this way by the original code...
I remain totally willing to make it better. :-)
Cheers.
next prev parent reply other threads:[~2014-04-27 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-27 17:11 [PATCH 1/2] staging/rtl8192e: Erroneous return codes (types and values) Dominique van den Broeck
2014-04-27 17:11 ` [PATCH 2/2] staging/rtl8192e: userspace ptr deref + incorrect declarations Dominique van den Broeck
2014-04-27 17:47 ` Levente Kurusa
2014-04-27 18:05 ` Dominique van den Broeck [this message]
2014-05-04 0:22 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398621918.30622.6.camel@wisdom \
--to=domdevlin@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=levex@linux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.