All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH 8/8] drm: Make drm_crtc_helper_disable() return void
Date: Tue, 29 Apr 2014 11:44:39 +0200	[thread overview]
Message-ID: <1398764679-7933-9-git-send-email-thierry.reding@gmail.com> (raw)
In-Reply-To: <1398764679-7933-1-git-send-email-thierry.reding@gmail.com>

From: Thierry Reding <treding@nvidia.com>

The function can never fail, and always returns 0, so it may just as
well not return anything.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpu/drm/drm_crtc_helper.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index df281b54db01..72ce15e21bcd 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -387,8 +387,7 @@ done:
 }
 EXPORT_SYMBOL(drm_crtc_helper_set_mode);
 
-
-static int
+static void
 drm_crtc_helper_disable(struct drm_crtc *crtc)
 {
 	struct drm_device *dev = crtc->dev;
@@ -417,7 +416,6 @@ drm_crtc_helper_disable(struct drm_crtc *crtc)
 	}
 
 	__drm_helper_disable_unused_functions(dev);
-	return 0;
 }
 
 /**
@@ -468,7 +466,8 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set)
 				(int)set->num_connectors, set->x, set->y);
 	} else {
 		DRM_DEBUG_KMS("[CRTC:%d] [NOFB]\n", set->crtc->base.id);
-		return drm_crtc_helper_disable(set->crtc);
+		drm_crtc_helper_disable(set->crtc);
+		return 0;
 	}
 
 	dev = set->crtc->dev;
-- 
1.9.2

  parent reply	other threads:[~2014-04-29  9:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-29  9:44 [PATCH 0/8] drm: Various minor fixes and cleanups Thierry Reding
2014-04-29  9:44 ` [PATCH 1/8] drm: Try to acquire modeset lock on panic or sysrq Thierry Reding
2014-04-29  9:44 ` [PATCH 2/8] drm/edid: Drop revision argument for drm_mode_std() Thierry Reding
2014-04-29  9:44 ` [PATCH 3/8] drm/edid: Cleanup kerneldoc Thierry Reding
2014-04-29 10:32   ` Daniel Vetter
2014-04-29  9:44 ` [PATCH 4/8] drm/fb: Fix typos Thierry Reding
2014-04-29  9:44 ` [PATCH 5/8] drm: Fixup flip-work kerneldoc Thierry Reding
2014-04-29  9:44 ` [PATCH 6/8] drm/dp: Fix typo in comment Thierry Reding
2014-04-29  9:44 ` [PATCH 7/8] drm: Fix indentation of closing brace Thierry Reding
2014-04-29  9:44 ` Thierry Reding [this message]
2014-04-29 10:35 ` [PATCH 0/8] drm: Various minor fixes and cleanups Daniel Vetter
2014-04-29 14:28   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398764679-7933-9-git-send-email-thierry.reding@gmail.com \
    --to=thierry.reding@gmail.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.