From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH] tools/mfn-dump: Fixes to 'dump-p2m'
Date: Tue, 29 Apr 2014 17:25:23 +0200
Message-ID: <1398785123.16933.16.camel@Solace>
References: <1398373587-26948-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8837648151948061931=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1398373587-26948-1-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

--===============8837648151948061931==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-XEH39err+oPKUMcZRuEc"

--=-XEH39err+oPKUMcZRuEc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On gio, 2014-04-24 at 22:06 +0100, Andrew Cooper wrote:
> * Don't walk off the end of p2m_table under the mistaken impression that =
it
>   contains toolstack unsigned longs.  Despite its array type it contains =
guest
>   unsigned longs so unconditionally needs casting to the guest width to u=
se
>   correctly.  Furthermore, a 64bit toolstack must be extra careful when i=
t
>   finds a 32bit guest's INVALID_MFN.
>=20
> * Drop 'mapped' and 'pinned' descriptions.  This are both bogus, includin=
g all
>   uses of the is_mapped() macro.
>=20
Just a question, what do you mean by 'bogus' here? About pinned, I think
I see it, and I like the way you put it in the patch. About 'mapped' and
is_mapped()? Do you mean to say it's not useful information here?

Again, just curious.

> * Rearrange the type name printing to be more concise.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Dario Faggioli <dario.faggioli@citrix.com>
>
In any case, I think this is all correct and I like the new look of the
code, so:

Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Sorry again for the delay,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-XEH39err+oPKUMcZRuEc
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iEYEABECAAYFAlNfxGMACgkQk4XaBE3IOsRodACcCaGs0jpvQ9oWMh0P4QsdILbR
Vp4AnRySIAPiHMVlW98ynFqQx77lDB2n
=Jpy5
-----END PGP SIGNATURE-----

--=-XEH39err+oPKUMcZRuEc--


--===============8837648151948061931==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============8837648151948061931==--