From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH] tools/mfn-dump: Fixes to 'dump-p2m'
Date: Wed, 30 Apr 2014 00:35:17 +0200
Message-ID: <1398810917.16933.34.camel@Solace>
References: <1398373587-26948-1-git-send-email-andrew.cooper3@citrix.com>
	<1398785123.16933.16.camel@Solace> <535FD5B5.30208@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6742064527424781219=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <535FD5B5.30208@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

--===============6742064527424781219==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-DhXSU1HmnAJgR/Nje7Kd"

--=-DhXSU1HmnAJgR/Nje7Kd
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On mar, 2014-04-29 at 17:39 +0100, Andrew Cooper wrote:

> The top bit of the type has nothing to do with mappings, or certainly
> nothing that I am aware of, having successfully rewritten PV migration
> from scratch.
>=20
> The guest can still have mappings to its pinned pagetables, which
> would have the top bit of the type set.
>=20
> In xc_domain_save.c, this macro is used 4 times.  3 are used on mfns
> and 1 is used on a type (for a bit of debugging code which appears
> dead anyway).  I expect noone has every tried migrating a PV domain
> whose pages are located in mfns with the 44th bit set.
>=20
Right. The fact that such macro is present in xc_domain_save.c was the
exact region why I was asking. :-)

> So by bogus, I mean the macro itself, and all uses of it.
>=20
> My best guess is that is some vestigial code left over from a previous
> way of doing things, although I didn't encounter anything related to
> this in code archaeology I performed when trying to work out why the
> legacy migration did certain things the way they did.
>=20
I see. Makes sense, thanks for clearing my doubts. :-)

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-DhXSU1HmnAJgR/Nje7Kd
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iEYEABECAAYFAlNgKSYACgkQk4XaBE3IOsQVEwCgqr9uw/pvngdg4znX/KgXsEIx
+qoAn2BrNgAiYMT9FM6NgiSx1Gx+Dtq1
=0Ad2
-----END PGP SIGNATURE-----

--=-DhXSU1HmnAJgR/Nje7Kd--


--===============6742064527424781219==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============6742064527424781219==--