From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v4 1/2] common/board_f: Initialized global data for generic board
Date: Fri, 2 May 2014 19:17:56 -0500 [thread overview]
Message-ID: <1399076276.15726.84.camel@snotra.buserror.net> (raw)
In-Reply-To: <536434E0.70300@freescale.com>
On Fri, 2014-05-02 at 17:14 -0700, York Sun wrote:
> On 05/01/2014 07:45 PM, Simon Glass wrote:
> > On 1 May 2014 16:00, York Sun <yorksun@freescale.com> wrote:
> >> Some platforms (tested on mpc85xx, mpc86xx) use global data before calling
> >> function baord_inti_f(). The data should not be cleared later. Any arch
> >> which uses global data in generic board board_init_f() should define
> >> CONFIG_SYS_GENERIC_GLOBAL_DATA.
> >>
> >> Signed-off-by: York Sun <yorksun@freescale.com>
> >> CC: Scott Wood <scottwood@freescale.com>
> >> CC: Simon Glass <sjg@chromium.org>
> >> CC: Albert ARIBAUD <albert.u.boot@aribaud.net>
> >> ---
> >> Change log
> >>
> >> v4: Replace with CONFIG_SYS_GENERIC_GLOBAL_DATA, a positive logic
> >> v3: Introduce CONFIG_SYS_EARLY_GD instead of using a list
> >> v2: Instead of adding back gd init for all PPC, preserve gd for mpc85xx and mpc86xx.
> >>
> >> README | 6 ++++++
> >> arch/arc/include/asm/config.h | 2 ++
> >> arch/arm/include/asm/config.h | 2 ++
> >> arch/mips/include/asm/config.h | 2 ++
> >
> > I think you will need sandbox also. Otherwise looks good.
> >
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> >
>
> Simon,
>
> Sandbox doesn't have CONFIG_SYS_GENERIC_BOARD defined yet. Did you convert it
> recently?
Look in arch/sandbox/config.mk. Likewise with
arch/x86/include/asm/config.h.
-Scott
prev parent reply other threads:[~2014-05-03 0:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 23:00 [U-Boot] [Patch v4 1/2] common/board_f: Initialized global data for generic board York Sun
2014-05-01 23:00 ` [U-Boot] [Patch v4 2/2] common/board_f: Fix size variable York Sun
2014-05-02 2:45 ` [U-Boot] [Patch v4 1/2] common/board_f: Initialized global data for generic board Simon Glass
2014-05-03 0:14 ` York Sun
2014-05-03 0:17 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399076276.15726.84.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.