From: Daniel Mack <zonque@gmail.com>
To: broonie@kernel.org, alsa-devel@alsa-project.org
Cc: Daniel Mack <zonque@gmail.com>
Subject: [PATCH 1/2] ASoC: sta350: fix DT bindings document
Date: Mon, 5 May 2014 11:49:22 +0200 [thread overview]
Message-ID: <1399283363-16441-1-git-send-email-zonque@gmail.com> (raw)
Fix a misleading property description, and denote the fact that
st,output-conf and st,ch*-output-mapping have to be passed as /bits/ 8.
Signed-off-by: Daniel Mack <zonque@gmail.com>
---
Documentation/devicetree/bindings/sound/st,sta350.txt | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/st,sta350.txt b/Documentation/devicetree/bindings/sound/st,sta350.txt
index 9501888..ecd7a62 100644
--- a/Documentation/devicetree/bindings/sound/st,sta350.txt
+++ b/Documentation/devicetree/bindings/sound/st,sta350.txt
@@ -25,6 +25,7 @@ Optional properties:
2: 2 Channel (Full-Bridge) Power, 1 Channel FFX
3: 1 Channel Mono-Parallel
If parameter is missing, mode 0 will be enabled.
+ This property has to be specified as '/bits/ 8' value.
- st,ch1-output-mapping: Channel 1 output mapping
- st,ch2-output-mapping: Channel 2 output mapping
@@ -33,6 +34,7 @@ Optional properties:
1: Channel 2
2: Channel 3
If parameter is missing, channel 1 is choosen.
+ This properties have to be specified as '/bits/ 8' values.
- st,thermal-warning-recover:
If present, thermal warning recovery is enabled.
@@ -82,7 +84,7 @@ Optional properties:
If not present, preset DC coefficient is used.
- st,invalid-input-detect-mute:
- If not present, automatic invalid input detect mute is enabled.
+ If present, automatic invalid input detect mute is enabled.
@@ -93,12 +95,12 @@ codec: sta350@38 {
reg = <0x1c>;
reset-gpios = <&gpio1 19 0>;
power-down-gpios = <&gpio1 16 0>;
- st,output-conf = <0x3>; // set output to 2-channel
+ st,output-conf = /bits/ 8 <0x3>; // set output to 2-channel
// (full-bridge) power,
// 2-channel data-out
- st,ch1-output-mapping = <0>; // set channel 1 output ch 1
- st,ch2-output-mapping = <0>; // set channel 2 output ch 1
- st,ch3-output-mapping = <0>; // set channel 3 output ch 1
+ st,ch1-output-mapping = /bits/ 8 <0>; // set channel 1 output ch 1
+ st,ch2-output-mapping = /bits/ 8 <0>; // set channel 2 output ch 1
+ st,ch3-output-mapping = /bits/ 8 <0>; // set channel 3 output ch 1
st,max-power-correction; // enables power bridge
// correction for THD reduction
// near maximum power output
--
1.9.0
next reply other threads:[~2014-05-05 9:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 9:49 Daniel Mack [this message]
2014-05-05 9:49 ` [PATCH 2/2] ASoC: sta350: add support for bits in miscellaneous registers Daniel Mack
2014-05-05 19:55 ` Mark Brown
2014-05-05 19:52 ` [PATCH 1/2] ASoC: sta350: fix DT bindings document Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399283363-16441-1-git-send-email-zonque@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.