From: Brian Foster <bfoster@redhat.com>
To: xfs@oss.sgi.com
Subject: [PATCH v4 01/20] xfs: refactor xfs_ialloc_btree.c to support multiple inobt numbers
Date: Wed, 7 May 2014 08:21:40 -0400 [thread overview]
Message-ID: <1399465319-65066-2-git-send-email-bfoster@redhat.com> (raw)
In-Reply-To: <1399465319-65066-1-git-send-email-bfoster@redhat.com>
The introduction of the free inode btree (finobt) requires that
xfs_ialloc_btree.c handle multiple trees. Refactor xfs_ialloc_btree.c
so the caller specifies the btree type on cursor initialization to
prepare for addition of the finobt.
Signed-off-by: Brian Foster <bfoster@redhat.com>
---
include/xfs_ialloc_btree.h | 3 ++-
libxfs/xfs_ialloc.c | 8 ++++----
libxfs/xfs_ialloc_btree.c | 8 +++++---
3 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/include/xfs_ialloc_btree.h b/include/xfs_ialloc_btree.h
index f38b220..d7ebea7 100644
--- a/include/xfs_ialloc_btree.h
+++ b/include/xfs_ialloc_btree.h
@@ -58,7 +58,8 @@ struct xfs_mount;
((index) - 1) * sizeof(xfs_inobt_ptr_t)))
extern struct xfs_btree_cur *xfs_inobt_init_cursor(struct xfs_mount *,
- struct xfs_trans *, struct xfs_buf *, xfs_agnumber_t);
+ struct xfs_trans *, struct xfs_buf *, xfs_agnumber_t,
+ xfs_btnum_t);
extern int xfs_inobt_maxrecs(struct xfs_mount *, int, int);
#endif /* __XFS_IALLOC_BTREE_H__ */
diff --git a/libxfs/xfs_ialloc.c b/libxfs/xfs_ialloc.c
index c19d84a..d4a4511 100644
--- a/libxfs/xfs_ialloc.c
+++ b/libxfs/xfs_ialloc.c
@@ -432,7 +432,7 @@ xfs_ialloc_ag_alloc(
/*
* Insert records describing the new inode chunk into the btree.
*/
- cur = xfs_inobt_init_cursor(args.mp, tp, agbp, agno);
+ cur = xfs_inobt_init_cursor(args.mp, tp, agbp, agno, XFS_BTNUM_INO);
for (thisino = newino;
thisino < newino + newlen;
thisino += XFS_INODES_PER_CHUNK) {
@@ -678,7 +678,7 @@ xfs_dialloc_ag(
ASSERT(pag->pagi_freecount > 0);
restart_pagno:
- cur = xfs_inobt_init_cursor(mp, tp, agbp, agno);
+ cur = xfs_inobt_init_cursor(mp, tp, agbp, agno, XFS_BTNUM_INO);
/*
* If pagino is 0 (this is the root inode allocation) use newino.
* This must work because we've just allocated some.
@@ -1140,7 +1140,7 @@ xfs_difree(
/*
* Initialize the cursor.
*/
- cur = xfs_inobt_init_cursor(mp, tp, agbp, agno);
+ cur = xfs_inobt_init_cursor(mp, tp, agbp, agno, XFS_BTNUM_INO);
error = xfs_check_agi_freecount(cur, agi);
if (error)
@@ -1271,7 +1271,7 @@ xfs_imap_lookup(
* we have a record, we need to ensure it contains the inode number
* we are looking up.
*/
- cur = xfs_inobt_init_cursor(mp, tp, agbp, agno);
+ cur = xfs_inobt_init_cursor(mp, tp, agbp, agno, XFS_BTNUM_INO);
error = xfs_inobt_lookup(cur, agino, XFS_LOOKUP_LE, &i);
if (!error) {
if (i)
diff --git a/libxfs/xfs_ialloc_btree.c b/libxfs/xfs_ialloc_btree.c
index 0a29d73..2027bc6 100644
--- a/libxfs/xfs_ialloc_btree.c
+++ b/libxfs/xfs_ialloc_btree.c
@@ -30,7 +30,8 @@ xfs_inobt_dup_cursor(
struct xfs_btree_cur *cur)
{
return xfs_inobt_init_cursor(cur->bc_mp, cur->bc_tp,
- cur->bc_private.a.agbp, cur->bc_private.a.agno);
+ cur->bc_private.a.agbp, cur->bc_private.a.agno,
+ cur->bc_btnum);
}
STATIC void
@@ -379,7 +380,8 @@ xfs_inobt_init_cursor(
struct xfs_mount *mp, /* file system mount point */
struct xfs_trans *tp, /* transaction pointer */
struct xfs_buf *agbp, /* buffer for agi structure */
- xfs_agnumber_t agno) /* allocation group number */
+ xfs_agnumber_t agno, /* allocation group number */
+ xfs_btnum_t btnum) /* ialloc or free ino btree */
{
struct xfs_agi *agi = XFS_BUF_TO_AGI(agbp);
struct xfs_btree_cur *cur;
@@ -389,7 +391,7 @@ xfs_inobt_init_cursor(
cur->bc_tp = tp;
cur->bc_mp = mp;
cur->bc_nlevels = be32_to_cpu(agi->agi_level);
- cur->bc_btnum = XFS_BTNUM_INO;
+ cur->bc_btnum = btnum;
cur->bc_blocklog = mp->m_sb.sb_blocklog;
cur->bc_ops = &xfs_inobt_ops;
--
1.8.3.1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-05-07 12:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 12:21 [PATCH v4 00/20] xfsprogs: introduce the free inode btree Brian Foster
2014-05-07 12:21 ` Brian Foster [this message]
2014-05-07 12:21 ` [PATCH v4 02/20] xfs: reserve v5 superblock read-only compat. feature bit for finobt Brian Foster
2014-05-07 12:21 ` [PATCH v4 03/20] xfs: support the XFS_BTNUM_FINOBT free inode btree type Brian Foster
2014-05-07 12:21 ` [PATCH v4 04/20] xfs: update inode allocation/free transaction reservations for finobt Brian Foster
2014-05-07 12:21 ` [PATCH v4 05/20] xfs: insert newly allocated inode chunks into the finobt Brian Foster
2014-05-07 12:21 ` [PATCH v4 06/20] xfs: use and update the finobt on inode allocation Brian Foster
2014-05-07 12:21 ` [PATCH v4 07/20] xfs: refactor xfs_difree() inobt bits into xfs_difree_inobt() helper Brian Foster
2014-05-07 12:21 ` [PATCH v4 08/20] xfs: update the finobt on inode free Brian Foster
2014-05-07 12:21 ` [PATCH v4 09/20] xfs: report finobt status in fs geometry Brian Foster
2014-05-07 12:21 ` [PATCH v4 10/20] xfs: enable the finobt feature on v5 superblocks Brian Foster
2014-05-07 12:21 ` [PATCH v4 11/20] xfsprogs/mkfs: finobt mkfs support Brian Foster
2014-05-07 12:21 ` [PATCH v4 12/20] xfsprogs/db: finobt support Brian Foster
2014-05-07 12:21 ` [PATCH v4 13/20] xfsprogs/repair: account for finobt in ag 0 geometry pre-calculation Brian Foster
2014-05-07 12:21 ` [PATCH v4 14/20] xfsprogs/repair: phase 2 finobt scan Brian Foster
2014-05-07 12:21 ` [PATCH v4 15/20] xfsprogs/repair: pass btree block magic as param to build_ino_tree() Brian Foster
2014-05-07 12:21 ` [PATCH v4 16/20] xfsprogs/repair: pull the build_agi() call up out of the inode tree build Brian Foster
2014-05-07 12:21 ` [PATCH v4 17/20] xfsprogs/repair: helpers for finding in-core inode records w/ free inodes Brian Foster
2014-05-07 12:21 ` [PATCH v4 18/20] xfsprogs/repair: reconstruct the finobt in phase 5 Brian Foster
2014-05-07 12:21 ` [PATCH v4 19/20] xfsprogs/growfs: report finobt status in fs geometry (xfs_info) Brian Foster
2014-05-07 12:21 ` [PATCH v4 20/20] xfsprogs/db: add finobt support to metadump Brian Foster
2014-05-26 22:40 ` [PATCH v4 00/20] xfsprogs: introduce the free inode btree Dave Chinner
2014-05-27 12:06 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399465319-65066-2-git-send-email-bfoster@redhat.com \
--to=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.