From: arunks.linux@gmail.com (arunks.linux at gmail.com)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: Disable preemption along with interrupts during shutdown
Date: Thu, 8 May 2014 18:53:31 +0530 [thread overview]
Message-ID: <1399555411-15330-1-git-send-email-arunks.linux@gmail.com> (raw)
From: Arun KS <arunks.linux@gmail.com>
'irqs disabled' is funtamentally unsafe way of disabling preemption.
Any spin_unlock() decreasing the preemption count to 0 might trigger
a reschedule. A simple printk() might trigger a reschedule.
To be on safe side disable preemption as well using preempt_disable()
Signed-off-by: Arun KS <getarunks@gmail.com>
---
arch/arm/kernel/process.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 81ef686..9ecb7b5 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -193,6 +193,7 @@ void machine_shutdown(void)
void machine_halt(void)
{
local_irq_disable();
+ preempt_disable();
smp_send_stop();
local_irq_disable();
@@ -208,6 +209,7 @@ void machine_halt(void)
void machine_power_off(void)
{
local_irq_disable();
+ preempt_disable();
smp_send_stop();
if (pm_power_off)
@@ -228,6 +230,7 @@ void machine_power_off(void)
void machine_restart(char *cmd)
{
local_irq_disable();
+ preempt_disable();
smp_send_stop();
arm_pm_restart(reboot_mode, cmd);
--
1.7.6
next reply other threads:[~2014-05-08 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 13:23 arunks.linux at gmail.com [this message]
2014-05-08 13:49 ` ARM: Disable preemption along with interrupts during shutdown Russell King - ARM Linux
2014-05-08 14:16 ` Arun KS
2014-05-08 15:22 ` Russell King - ARM Linux
2014-05-09 2:43 ` Arun KS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399555411-15330-1-git-send-email-arunks.linux@gmail.com \
--to=arunks.linux@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.