From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCHSET cgroup/for-3.16] cgroup: use css->refcnt for cgroup reference counting
Date: Fri, 9 May 2014 17:13:26 -0400 [thread overview]
Message-ID: <1399670015-23463-1-git-send-email-tj@kernel.org> (raw)
Hello,
Currently, cgroup and css (cgroup_subsys_state) are separately
reference counted. cgroup->refcnt is an atomic_t and css->refcnt is a
percpu_ref. css is becoming the primary structural block and used
widely in various operaitons. cgroup already has a css embedded in it
(cgroup->dummy_css) to use as its proxy in such operations; however,
there still are quite a few differences between cgroup and css
handling limitng how cgroup->dummy_css can be used.
This patchset makes cgroup use the embedded css's refcnt for reference
counting. This closes one of the gaps between an cgroup embedded css,
which is renamed to cgroup->self early in the patchset, and a normal
css and will allow more unified handling of cgroups and csses. In
addition, this makes cgroup refcnting use percpu_ref too, which is a
lot more scalable than an atomic_t.
Ultimately, it'd make things far simpler to assign a proper
cgroup_subsys to the cgroup embedded csses and handle them the same as
other csses; however, we can't yet do it thanks to multiple
hierarchies as we end up with multiple csses of the same subsystem for
the same task, but in the very long term, if multiple hierarchies can
be removed, that's where it's headed.
This patchset contains the following nine patches.
0001-cgroup-use-restart_syscall-for-mount-retries.patch
0002-cgroup-rename-cgroup-dummy_css-to-self-and-move-it-t.patch
0003-cgroup-separate-out-cgroup_has_live_children-from-cg.patch
0004-cgroup-move-check_for_release-parent-call-to-the-end.patch
0005-cgroup-move-cgroup-sibling-unlinking-to-cgroup_put.patch
0006-cgroup-remove-cgroup_destory_css_killed.patch
0007-cgroup-bounce-css-release-through-css-destroy_work.patch
0008-cgroup-enable-refcnting-for-root-csses.patch
0009-cgroup-use-cgroup-self.refcnt-for-cgroup-refcnting.patch
0001-0003 are prep patches.
0004-0006 remove cgroup_destroy_css_killed(). This brings cgroup's
destruction path closer to css's so that they can be merged.
0007-0009 make cgroup use the embedded css's refcnt.
This pachset is on top of
b9a63d0116e8 ("Merge branch 'for-3.16' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu into for-3.16")
+ [1] [PATCHSET v2 cgroup/for-3.16] cgroup: post unified hierarchy fixes and updates
+ [2] (REFRESHED) [PATCHSET cgroup/for-3.16] cgroup: implement cftype->write()
+ [3] (REFRESHED) [PATCHSET cgroup/for-3.16] cgroup: remove cgroup_tree_mutex
and available in the following git branch.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-use-css-ref
diffstat follows. Thanks.
include/linux/cgroup.h | 25 ----
kernel/cgroup.c | 284 ++++++++++++++++++++++---------------------------
2 files changed, 136 insertions(+), 173 deletions(-)
--
tejun
[1] http://lkml.kernel.org/g/1399663975-315-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
[2] http://lkml.kernel.org/g/20140509195059.GE4486-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org
[3] http://lkml.kernel.org/g/20140509195827.GG4486-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: lizefan@huawei.com
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCHSET cgroup/for-3.16] cgroup: use css->refcnt for cgroup reference counting
Date: Fri, 9 May 2014 17:13:26 -0400 [thread overview]
Message-ID: <1399670015-23463-1-git-send-email-tj@kernel.org> (raw)
Hello,
Currently, cgroup and css (cgroup_subsys_state) are separately
reference counted. cgroup->refcnt is an atomic_t and css->refcnt is a
percpu_ref. css is becoming the primary structural block and used
widely in various operaitons. cgroup already has a css embedded in it
(cgroup->dummy_css) to use as its proxy in such operations; however,
there still are quite a few differences between cgroup and css
handling limitng how cgroup->dummy_css can be used.
This patchset makes cgroup use the embedded css's refcnt for reference
counting. This closes one of the gaps between an cgroup embedded css,
which is renamed to cgroup->self early in the patchset, and a normal
css and will allow more unified handling of cgroups and csses. In
addition, this makes cgroup refcnting use percpu_ref too, which is a
lot more scalable than an atomic_t.
Ultimately, it'd make things far simpler to assign a proper
cgroup_subsys to the cgroup embedded csses and handle them the same as
other csses; however, we can't yet do it thanks to multiple
hierarchies as we end up with multiple csses of the same subsystem for
the same task, but in the very long term, if multiple hierarchies can
be removed, that's where it's headed.
This patchset contains the following nine patches.
0001-cgroup-use-restart_syscall-for-mount-retries.patch
0002-cgroup-rename-cgroup-dummy_css-to-self-and-move-it-t.patch
0003-cgroup-separate-out-cgroup_has_live_children-from-cg.patch
0004-cgroup-move-check_for_release-parent-call-to-the-end.patch
0005-cgroup-move-cgroup-sibling-unlinking-to-cgroup_put.patch
0006-cgroup-remove-cgroup_destory_css_killed.patch
0007-cgroup-bounce-css-release-through-css-destroy_work.patch
0008-cgroup-enable-refcnting-for-root-csses.patch
0009-cgroup-use-cgroup-self.refcnt-for-cgroup-refcnting.patch
0001-0003 are prep patches.
0004-0006 remove cgroup_destroy_css_killed(). This brings cgroup's
destruction path closer to css's so that they can be merged.
0007-0009 make cgroup use the embedded css's refcnt.
This pachset is on top of
b9a63d0116e8 ("Merge branch 'for-3.16' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu into for-3.16")
+ [1] [PATCHSET v2 cgroup/for-3.16] cgroup: post unified hierarchy fixes and updates
+ [2] (REFRESHED) [PATCHSET cgroup/for-3.16] cgroup: implement cftype->write()
+ [3] (REFRESHED) [PATCHSET cgroup/for-3.16] cgroup: remove cgroup_tree_mutex
and available in the following git branch.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-use-css-ref
diffstat follows. Thanks.
include/linux/cgroup.h | 25 ----
kernel/cgroup.c | 284 ++++++++++++++++++++++---------------------------
2 files changed, 136 insertions(+), 173 deletions(-)
--
tejun
[1] http://lkml.kernel.org/g/1399663975-315-1-git-send-email-tj@kernel.org
[2] http://lkml.kernel.org/g/20140509195059.GE4486@htj.dyndns.org
[3] http://lkml.kernel.org/g/20140509195827.GG4486@htj.dyndns.org
next reply other threads:[~2014-05-09 21:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 21:13 Tejun Heo [this message]
2014-05-09 21:13 ` [PATCHSET cgroup/for-3.16] cgroup: use css->refcnt for cgroup reference counting Tejun Heo
2014-05-09 21:13 ` [PATCH 2/9] cgroup: rename cgroup->dummy_css to ->self and move it to the top Tejun Heo
[not found] ` <1399670015-23463-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-09 21:13 ` [PATCH 1/9] cgroup: use restart_syscall() for mount retries Tejun Heo
2014-05-09 21:13 ` Tejun Heo
[not found] ` <1399670015-23463-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-14 2:53 ` Li Zefan
2014-05-14 2:53 ` Li Zefan
2014-05-14 13:12 ` [PATCH v2 " Tejun Heo
2014-05-14 13:12 ` Tejun Heo
2014-05-09 21:13 ` [PATCH 3/9] cgroup: separate out cgroup_has_live_children() from cgroup_destroy_locked() Tejun Heo
2014-05-09 21:13 ` Tejun Heo
2014-05-09 21:13 ` [PATCH 5/9] cgroup: move cgroup->sibling unlinking to cgroup_put() Tejun Heo
2014-05-09 21:13 ` Tejun Heo
2014-05-09 21:13 ` [PATCH 8/9] cgroup: enable refcnting for root csses Tejun Heo
2014-05-09 21:13 ` Tejun Heo
2014-05-14 3:15 ` [PATCHSET cgroup/for-3.16] cgroup: use css->refcnt for cgroup reference counting Li Zefan
2014-05-14 3:15 ` Li Zefan
2014-05-14 17:04 ` Tejun Heo
2014-05-14 17:04 ` Tejun Heo
2014-05-09 21:13 ` [PATCH 4/9] cgroup: move check_for_release(parent) call to the end of cgroup_destroy_locked() Tejun Heo
2014-05-09 21:13 ` [PATCH 6/9] cgroup: remove cgroup_destory_css_killed() Tejun Heo
2014-05-09 21:13 ` [PATCH 7/9] cgroup: bounce css release through css->destroy_work Tejun Heo
2014-05-09 21:13 ` [PATCH 9/9] cgroup: use cgroup->self.refcnt for cgroup refcnting Tejun Heo
[not found] ` <1399670015-23463-10-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-15 19:07 ` Stephen Warren
2014-05-15 19:07 ` Stephen Warren
2014-05-15 19:07 ` Stephen Warren
2014-05-15 21:56 ` Stephen Warren
2014-05-15 21:56 ` Stephen Warren
2014-05-16 14:37 ` Tejun Heo
2014-05-16 14:37 ` Tejun Heo
[not found] ` <20140516143718.GA5379-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-05-16 15:43 ` [PATCH cgroup/for-3.16] cgroup: introduce CSS_NO_REF and skip refcnting on normal root csses Tejun Heo
2014-05-16 15:43 ` Tejun Heo
2014-05-16 15:43 ` Tejun Heo
[not found] ` <20140516154330.GB5379-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-05-16 16:59 ` Stephen Warren
2014-05-16 16:59 ` Stephen Warren
2014-05-16 16:59 ` Stephen Warren
[not found] ` <537643F9.1030303-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-16 17:09 ` [PATCH v2 " Tejun Heo
2014-05-16 17:09 ` Tejun Heo
2014-05-16 17:09 ` Tejun Heo
[not found] ` <20140516170959.GG5379-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-05-16 17:19 ` Stephen Warren
2014-05-16 17:19 ` Stephen Warren
2014-05-16 17:19 ` Stephen Warren
[not found] ` <5376489C.9010902-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-16 17:23 ` Tejun Heo
2014-05-16 17:23 ` Tejun Heo
2014-05-16 17:23 ` Tejun Heo
2014-05-13 16:59 ` [PATCHSET cgroup/for-3.16] cgroup: use css->refcnt for cgroup reference counting Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399670015-23463-1-git-send-email-tj@kernel.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.