From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: [PATCH 1/9] cgroup: use restart_syscall() for mount retries
Date: Fri, 9 May 2014 17:13:27 -0400 [thread overview]
Message-ID: <1399670015-23463-2-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1399670015-23463-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
cgroup_mount() uses dumb delay-and-retry logic to wait for cgroup_root
which is being destroyed. The retry currently loops inside
cgroup_mount() proper. This patch makes it return with
restart_syscall() instead so that retry travels out to userland
boundary.
This slightly simplifies the logic and more importantly makes the
retry logic behave better when the wait for some reason becomes
lengthy or infinite by allowing the operation to be suspended or
terminated from userland.
Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
kernel/cgroup.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 3083c5a..2755f33 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1681,7 +1681,7 @@ static struct dentry *cgroup_mount(struct file_system_type *fs_type,
ret = parse_cgroupfs_options(data, &opts);
if (ret)
goto out_unlock;
-retry:
+
/* look for a matching existing root */
if (!opts.subsys_mask && !opts.none && !opts.name) {
cgrp_dfl_root_visible = true;
@@ -1740,8 +1740,7 @@ retry:
if (!atomic_inc_not_zero(&root->cgrp.refcnt)) {
mutex_unlock(&cgroup_mutex);
msleep(10);
- mutex_lock(&cgroup_mutex);
- goto retry;
+ return ERR_PTR(restart_syscall());
}
ret = 0;
--
1.9.0
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: lizefan@huawei.com
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
Tejun Heo <tj@kernel.org>
Subject: [PATCH 1/9] cgroup: use restart_syscall() for mount retries
Date: Fri, 9 May 2014 17:13:27 -0400 [thread overview]
Message-ID: <1399670015-23463-2-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1399670015-23463-1-git-send-email-tj@kernel.org>
cgroup_mount() uses dumb delay-and-retry logic to wait for cgroup_root
which is being destroyed. The retry currently loops inside
cgroup_mount() proper. This patch makes it return with
restart_syscall() instead so that retry travels out to userland
boundary.
This slightly simplifies the logic and more importantly makes the
retry logic behave better when the wait for some reason becomes
lengthy or infinite by allowing the operation to be suspended or
terminated from userland.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
kernel/cgroup.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 3083c5a..2755f33 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1681,7 +1681,7 @@ static struct dentry *cgroup_mount(struct file_system_type *fs_type,
ret = parse_cgroupfs_options(data, &opts);
if (ret)
goto out_unlock;
-retry:
+
/* look for a matching existing root */
if (!opts.subsys_mask && !opts.none && !opts.name) {
cgrp_dfl_root_visible = true;
@@ -1740,8 +1740,7 @@ retry:
if (!atomic_inc_not_zero(&root->cgrp.refcnt)) {
mutex_unlock(&cgroup_mutex);
msleep(10);
- mutex_lock(&cgroup_mutex);
- goto retry;
+ return ERR_PTR(restart_syscall());
}
ret = 0;
--
1.9.0
next prev parent reply other threads:[~2014-05-09 21:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 21:13 [PATCHSET cgroup/for-3.16] cgroup: use css->refcnt for cgroup reference counting Tejun Heo
2014-05-09 21:13 ` Tejun Heo
[not found] ` <1399670015-23463-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-09 21:13 ` Tejun Heo [this message]
2014-05-09 21:13 ` [PATCH 1/9] cgroup: use restart_syscall() for mount retries Tejun Heo
[not found] ` <1399670015-23463-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-14 2:53 ` Li Zefan
2014-05-14 2:53 ` Li Zefan
2014-05-14 13:12 ` [PATCH v2 " Tejun Heo
2014-05-14 13:12 ` Tejun Heo
2014-05-09 21:13 ` [PATCH 3/9] cgroup: separate out cgroup_has_live_children() from cgroup_destroy_locked() Tejun Heo
2014-05-09 21:13 ` Tejun Heo
2014-05-09 21:13 ` [PATCH 5/9] cgroup: move cgroup->sibling unlinking to cgroup_put() Tejun Heo
2014-05-09 21:13 ` Tejun Heo
2014-05-09 21:13 ` [PATCH 8/9] cgroup: enable refcnting for root csses Tejun Heo
2014-05-09 21:13 ` Tejun Heo
2014-05-14 3:15 ` [PATCHSET cgroup/for-3.16] cgroup: use css->refcnt for cgroup reference counting Li Zefan
2014-05-14 3:15 ` Li Zefan
2014-05-14 17:04 ` Tejun Heo
2014-05-14 17:04 ` Tejun Heo
2014-05-09 21:13 ` [PATCH 2/9] cgroup: rename cgroup->dummy_css to ->self and move it to the top Tejun Heo
2014-05-09 21:13 ` [PATCH 4/9] cgroup: move check_for_release(parent) call to the end of cgroup_destroy_locked() Tejun Heo
2014-05-09 21:13 ` [PATCH 6/9] cgroup: remove cgroup_destory_css_killed() Tejun Heo
2014-05-09 21:13 ` [PATCH 7/9] cgroup: bounce css release through css->destroy_work Tejun Heo
2014-05-09 21:13 ` [PATCH 9/9] cgroup: use cgroup->self.refcnt for cgroup refcnting Tejun Heo
[not found] ` <1399670015-23463-10-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-15 19:07 ` Stephen Warren
2014-05-15 19:07 ` Stephen Warren
2014-05-15 19:07 ` Stephen Warren
2014-05-15 21:56 ` Stephen Warren
2014-05-15 21:56 ` Stephen Warren
2014-05-16 14:37 ` Tejun Heo
2014-05-16 14:37 ` Tejun Heo
[not found] ` <20140516143718.GA5379-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-05-16 15:43 ` [PATCH cgroup/for-3.16] cgroup: introduce CSS_NO_REF and skip refcnting on normal root csses Tejun Heo
2014-05-16 15:43 ` Tejun Heo
2014-05-16 15:43 ` Tejun Heo
[not found] ` <20140516154330.GB5379-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-05-16 16:59 ` Stephen Warren
2014-05-16 16:59 ` Stephen Warren
2014-05-16 16:59 ` Stephen Warren
[not found] ` <537643F9.1030303-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-16 17:09 ` [PATCH v2 " Tejun Heo
2014-05-16 17:09 ` Tejun Heo
2014-05-16 17:09 ` Tejun Heo
[not found] ` <20140516170959.GG5379-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-05-16 17:19 ` Stephen Warren
2014-05-16 17:19 ` Stephen Warren
2014-05-16 17:19 ` Stephen Warren
[not found] ` <5376489C.9010902-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-16 17:23 ` Tejun Heo
2014-05-16 17:23 ` Tejun Heo
2014-05-16 17:23 ` Tejun Heo
2014-05-13 16:59 ` [PATCHSET cgroup/for-3.16] cgroup: use css->refcnt for cgroup reference counting Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399670015-23463-2-git-send-email-tj@kernel.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.