All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, davem@davemloft.net, mugunthanvnm@ti.com,
	ujhelyi.m@gmail.com, Daniel Mack <zonque@gmail.com>
Subject: [PATCH 3/3] net: of_mdio: don't store the length of a property if we don't need to
Date: Sat, 10 May 2014 18:37:55 +0200	[thread overview]
Message-ID: <1399739875-16434-4-git-send-email-zonque@gmail.com> (raw)
In-Reply-To: <1399739875-16434-1-git-send-email-zonque@gmail.com>

of_get_property() can be called with NULL as 2nd argument if the caller
is not interested in the length of a property. Use that here so we can
get rid of a variable.

Signed-off-by: Daniel Mack <zonque@gmail.com>
---
 drivers/of/of_mdio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index 931a977..f567210 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -151,7 +151,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
 	const __be32 *paddr;
 	u32 addr;
 	bool scanphys = false;
-	int rc, i, len;
+	int rc, i;
 
 	/* Mask out all PHYs from auto probing.  Instead the PHYs listed in
 	 * the device tree are populated after the bus has been registered */
@@ -188,7 +188,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
 	/* auto scan for PHYs with empty reg property */
 	for_each_available_child_of_node(np, child) {
 		/* Skip PHYs with reg property set */
-		paddr = of_get_property(child, "reg", &len);
+		paddr = of_get_property(child, "reg", NULL);
 		if (paddr)
 			continue;
 
-- 
1.9.0

  parent reply	other threads:[~2014-05-10 16:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-10 16:37 [PATCH 0/3] mdio: Parse DT nodes for auto-probed PHYs Daniel Mack
2014-05-10 16:37 ` [PATCH 1/3] net: of_mdio: factor out code to parse a phy's 'reg' property Daniel Mack
2014-05-10 20:29   ` Sergei Shtylyov
2014-05-13 17:07     ` David Miller
2014-05-13 17:21       ` Daniel Mack
2014-05-13 17:25         ` David Miller
2014-05-13 17:29           ` Daniel Mack
2014-05-10 16:37 ` [PATCH 2/3] net: of_mdio: add of_mdiobus_link_phydev() Daniel Mack
2014-05-23 19:35   ` Florian Fainelli
2014-05-24  7:25     ` Daniel Mack
2014-05-10 16:37 ` Daniel Mack [this message]
2014-05-13  4:33 ` [PATCH 0/3] mdio: Parse DT nodes for auto-probed PHYs Florian Fainelli
2014-05-22 18:18   ` Daniel Mack
2014-05-23 19:24     ` Florian Fainelli
2014-05-23 19:26       ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399739875-16434-4-git-send-email-zonque@gmail.com \
    --to=zonque@gmail.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=mugunthanvnm@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=ujhelyi.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.