From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 6/7] drm/i915/execlists: Direct submission from irq handler Date: Tue, 8 May 2018 11:54:27 +0100 Message-ID: <139c79a4-abfa-1eba-d131-28191a06a133@linux.intel.com> References: <20180507135731.10587-1-chris@chris-wilson.co.uk> <20180507135731.10587-6-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id E711C6E69E for ; Tue, 8 May 2018 10:54:29 +0000 (UTC) In-Reply-To: <20180507135731.10587-6-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA3LzA1LzIwMTggMTQ6NTcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBDb250aW51aW5nIHRo ZSB0aGVtZW0gb2YgYnlwYXNzaW5nIGtzb2Z0aXJxZCBsYXRlbmN5LCBhbHNvIGZpcnN0IHRyeSB0 bwo+IGRpcmVjdGx5IHN1Ym1pdCBmcm9tIHRoZSBDUyBpbnRlcnJ1cHQgaGFuZGxlciB0byBjbGVh ciB0aGUgRUxTUCBhbmQKPiBxdWV1ZSB0aGUgbmV4dC4KPiAKPiBJbiB0aGUgcGFzdCwgd2UgaGF2 ZSBiZWVuIGhlc2l0YW50IHRvIGRvIHRoaXMgYXMgdGhlIGNvbnRleHQgc3dpdGNoCj4gcHJvY2Vz c2luZyBoYXMgYmVlbiBxdWl0ZSBoZWF2eSwgcmVxdWlyaW5nIGZvcmNld2FrZWQgbW1pby4gSG93 ZXZlciwgYXMKPiB3ZSBub3cgY2FuIHJlYWQgdGhlIEdQVSBzdGF0ZSBmcm9tIHRoZSBjYWNoZWFi bGUgSFdTUCwgaXQgaXMgcmVsYXRpdmVseQo+IGNoZWFwIQo+IAo+IFN1Z2dlc3RlZC1ieTogVHZy dGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBD aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3Vs aW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfaXJxLmMgICAgICAgICAgICAgfCAxMyArKysrKystLS0tLS0tCj4gICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfc3VibWlzc2lvbi5jIHwgIDIgKysKPiAgIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCAgICAgfCAxNiArKysrKysrKysrKysrKysr Cj4gICAzIGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gaW5kZXggZjliYzNhYWE5MGQwLi43NzVjZjE2N2Q5 MzggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiBAQCAtMTQ2NSwxOSArMTQ2NSwxOCBA QCBnZW44X2NzX2lycV9oYW5kbGVyKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgdTMy IGlpcikKPiAgIAlzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAqIGNvbnN0IGV4ZWNsaXN0 cyA9ICZlbmdpbmUtPmV4ZWNsaXN0czsKPiAgIAlib29sIHRhc2tsZXQgPSBmYWxzZTsKPiAgIAo+ IC0JaWYgKGlpciAmIEdUX0NPTlRFWFRfU1dJVENIX0lOVEVSUlVQVCkgewo+IC0JCWlmIChSRUFE X09OQ0UoZW5naW5lLT5leGVjbGlzdHMuYWN0aXZlKSkKPiAtCQkJdGFza2xldCA9ICF0ZXN0X2Fu ZF9zZXRfYml0KEVOR0lORV9JUlFfRVhFQ0xJU1QsCj4gLQkJCQkJCSAgICAmZW5naW5lLT5pcnFf cG9zdGVkKTsKPiAtCX0KPiArCWlmIChpaXIgJiBHVF9DT05URVhUX1NXSVRDSF9JTlRFUlJVUFQg JiYgUkVBRF9PTkNFKGV4ZWNsaXN0cy0+YWN0aXZlKSkKPiArCQl0YXNrbGV0ID0gIXRlc3RfYW5k X3NldF9iaXQoRU5HSU5FX0lSUV9FWEVDTElTVCwKPiArCQkJCQkgICAgJmVuZ2luZS0+aXJxX3Bv c3RlZCk7Cj4gICAKPiAgIAlpZiAoaWlyICYgR1RfUkVOREVSX1VTRVJfSU5URVJSVVBUKSB7Cj4g ICAJCW5vdGlmeV9yaW5nKGVuZ2luZSk7Cj4gLQkJdGFza2xldCB8PSBVU0VTX0dVQ19TVUJNSVNT SU9OKGVuZ2luZS0+aTkxNSk7Cj4gKwkJaWYgKCF0ZXN0X2JpdChFTkdJTkVfSVJRX0VYRUNMSVNU LCAmZW5naW5lLT5pcnFfcG9zdGVkKSkKPiArCQkJdGFza2xldCA9IFVTRVNfR1VDX1NVQk1JU1NJ T04oZW5naW5lLT5pOTE1KTsKCkkgZG9uJ3QgdW5kZXJzdGFuZCB0aGlzIGNoYW5nZS4gSW4gdGhl IEd1QyBjYXNlIElSUV9FWEVDTElTVFMgaXMgbmV2ZXIgCnNldCBzbyB0aGUgY29uZGl0aW9uYWwg aXMgcG9pbnRlbGVzcy4gSW4gZXhlY2xpc3QgbW9kZSB1c2VyIGludGVycnVwdCAKaGFzIG5vdGhp bmcgdG8gZG8gd2l0aCBzY2hlZHVsaW5nIHRoZSB0YXNrbGV0LgoKPiAgIAl9Cj4gICAKPiAgIAlp ZiAodGFza2xldCkKPiAtCQl0YXNrbGV0X2hpX3NjaGVkdWxlKCZleGVjbGlzdHMtPnRhc2tsZXQp Owo+ICsJCWV4ZWNsaXN0c190YXNrbGV0KGV4ZWNsaXN0cyk7Cj4gICB9Cj4gICAKPiAgIHN0YXRp YyB2b2lkIGdlbjhfZ3RfaXJxX2FjayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX3N1Ym1pc3Npb24uYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19zdWJtaXNzaW9uLmMKPiBpbmRleCA2YmZl MzBhZjc4MjYuLjdkNDU0MmI0NmY1ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9ndWNfc3VibWlzc2lvbi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZ3VjX3N1Ym1pc3Npb24uYwo+IEBAIC03ODIsNiArNzgyLDggQEAgc3RhdGljIHZvaWQgZ3Vj X3N1Ym1pc3Npb25fdGFza2xldCh1bnNpZ25lZCBsb25nIGRhdGEpCj4gICAJc3RydWN0IGV4ZWNs aXN0X3BvcnQgKnBvcnQgPSBleGVjbGlzdHMtPnBvcnQ7Cj4gICAJc3RydWN0IGk5MTVfcmVxdWVz dCAqcnE7Cj4gICAKPiArCWNsZWFyX2JpdChFTkdJTkVfSVJRX0VYRUNMSVNULCAmZW5naW5lLT5p cnFfcG9zdGVkKTsKPiArCgpJIGRvbid0IHVuZGVyc3RhbmQgdGhpcyBlaXRoZXIgLSB0aGVyZSBp cyBubyBjaGFuZ2VkIGNvZGUgcGF0aCB3aGljaCAKc2V0cyB0aGlzIGluIEd1QyBtb2RlLgoKUmVn YXJkcywKClR2cnRrbwoKPiAgIAlycSA9IHBvcnRfcmVxdWVzdChwb3J0KTsKPiAgIAl3aGlsZSAo cnEgJiYgaTkxNV9yZXF1ZXN0X2NvbXBsZXRlZChycSkpIHsKPiAgIAkJdHJhY2VfaTkxNV9yZXF1 ZXN0X291dChycSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jp bmdidWZmZXIuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+IGlu ZGV4IGY1NTQ1MzkxZDc2YS4uZGE3ZTAwZmYyYzZiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3JpbmdidWZmZXIuaAo+IEBAIC03MTcsNiArNzE3LDIyIEBAIGV4ZWNsaXN0c19wb3J0 X2NvbXBsZXRlKHN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzICogY29uc3QgZXhlY2xpc3Rz LAo+ICAgCXJldHVybiBwb3J0Owo+ICAgfQo+ICAgCj4gK3N0YXRpYyBpbmxpbmUgdm9pZAo+ICtl eGVjbGlzdHNfdGFza2xldChzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAqIGNvbnN0IGV4 ZWNsaXN0cykKPiArewo+ICsJc3RydWN0IHRhc2tsZXRfc3RydWN0ICogY29uc3QgdCA9ICZleGVj bGlzdHMtPnRhc2tsZXQ7Cj4gKwo+ICsJaWYgKHVubGlrZWx5KGF0b21pY19yZWFkKCZ0LT5jb3Vu dCkpKSAvKiBHUFUgcmVzZXQgYWN0aXZlICovCj4gKwkJcmV0dXJuOwo+ICsKPiArCWlmICh0YXNr bGV0X3RyeWxvY2sodCkpIHsKPiArCQl0LT5mdW5jKHQtPmRhdGEpOwo+ICsJCXRhc2tsZXRfdW5s b2NrKHQpOwo+ICsJfSBlbHNlIHsKPiArCQl0YXNrbGV0X2hpX3NjaGVkdWxlKHQpOwo+ICsJfQo+ ICt9Cj4gKwo+ICAgc3RhdGljIGlubGluZSB1bnNpZ25lZCBpbnQKPiAgIGludGVsX2VuZ2luZV9m bGFnKGNvbnN0IHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIHsKPiAKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==