From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AED54C433E0 for ; Wed, 10 Jun 2020 02:19:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82F7320691 for ; Wed, 10 Jun 2020 02:19:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d8fXfi1l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725954AbgFJCTn (ORCPT ); Tue, 9 Jun 2020 22:19:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725798AbgFJCTm (ORCPT ); Tue, 9 Jun 2020 22:19:42 -0400 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDACDC05BD1E; Tue, 9 Jun 2020 19:19:41 -0700 (PDT) Received: by mail-ed1-x542.google.com with SMTP id w7so268231edt.1; Tue, 09 Jun 2020 19:19:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=6nDD9b7w8r1Mr/3MxkpIoE8zWpfhH3upQWRgRKaz8Zc=; b=d8fXfi1l7KInOy0Riqv289V5I5J1ZgSHL1mnqhUsN3TjXORhR79t8BUP4noaM6wxaV oF4HRekWinwy8NGtF9jeedNMhsCBi4m+sXOFRMrd4zvoeaAFaLCp+bO5Vs9NADVkdVmb E8XhMxF9b8v9mq893gxQNCngsZ/XC2oFr+hcO+higI+G2hcc+rErDQ3k1LLqDGmYSMIb WvswuoE/M1rnLHZyRUGJlOBg6FMpqstb0DLvcg2oOGa9ueadZj5PNTIKZ7JeNDh/XzyT EOky1jWF3pqojumstOj6V70bDCg4u20Tv8vBfPXCCddfq08EKytUPg24PfOscZ4ZNv/J eCZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6nDD9b7w8r1Mr/3MxkpIoE8zWpfhH3upQWRgRKaz8Zc=; b=RrF6vpttQIyGPG86B7RDWPKWHINqPLY2oWsy2LfnRS6fV+QBGJfmcxB8dFkM36Dhe4 xVm0DvVAkAJzsQvRpMGEEJ8FUhW3oWS26q/5/4+440ruLMuQm4slWs3OOwIQ9LDQ3Jc2 axvsnBukuWHnZh8Pnf4DkudgvNVjofIUGZiZJMmbncKdpf1nTaFoYmlW6JXBp4IPnyjr rVqyIrwhmdaumx7ihfJCHEsOKPJ1t72Mm8q+NiQwF8jHgcoJX4zw3SAcrNiuB+Ja1sCS 40oRQR75iYC73H8yU5IfthhS0ft7lpnFUyckpnt/RL+XYpGbWRX0c2Lwm7DtmqWHIaVn u33Q== X-Gm-Message-State: AOAM5338g8k5P9b1gI/QF9WbRpXg//OurhNqyWZtI8JGifUDrZFLk5aQ prfd5HqBJCUB6+vRPbCFvew= X-Google-Smtp-Source: ABdhPJyHM8AkM6LFw1w6gnIiVHMouyYrPLgZFtrZzLehkjZn/vUa+ZeZVaI4/d8rIky9PTihQBilQA== X-Received: by 2002:a50:b022:: with SMTP id i31mr595400edd.301.1591755580360; Tue, 09 Jun 2020 19:19:40 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id ss4sm14296639ejb.63.2020.06.09.19.19.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2020 19:19:39 -0700 (PDT) Subject: Re: [PATCH 2/4] soc: bcm: add BCM63xx power domain driver To: =?UTF-8?Q?=c3=81lvaro_Fern=c3=a1ndez_Rojas?= , hauke@hauke-m.de, zajec5@gmail.com, tsbogend@alpha.franken.de, robh+dt@kernel.org, jonas.gorski@gmail.com, bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20200609105244.4014823-1-noltari@gmail.com> <20200609105244.4014823-3-noltari@gmail.com> From: Florian Fainelli Message-ID: <13cc694b-c643-0f68-e510-062df5352eaa@gmail.com> Date: Tue, 9 Jun 2020 19:19:33 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200609105244.4014823-3-noltari@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 6/9/2020 3:52 AM, Álvaro Fernández Rojas wrote: > BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller > to enable/disable certain components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas > --- > drivers/soc/bcm/Kconfig | 8 + > drivers/soc/bcm/Makefile | 1 + > drivers/soc/bcm/bcm63xx-power.c | 374 ++++++++++++++++++++++++++++++++ I would create drivers/soc/bcm/bcm63xx because there are likely going to be more changes for BCM63xx DSL SOCs in the future that would land there, for instance the BCM63138 and newer SoCs have an entirely different reset controller using the on-chip micro controller that would be landing there. Can you also make sure that the MAINTAINERS file still matches that location? With respect to the code, given that you have defined #reset-cells = <1> in the Device Tree binding, I would expect that you create a header under include/dt-bindings/ which defines constants for the various SoCs which you are then using within your power domain provider driver. bcm2835-power.c is a good example of how this works for instance. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A674C433E1 for ; Wed, 10 Jun 2020 02:19:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB9B420691 for ; Wed, 10 Jun 2020 02:19:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ukywToUB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d8fXfi1l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB9B420691 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=EFE9NlDQvRreu/HgVjOmiBJdSS5bpotRfYN6RR761M8=; b=ukywToUBIA6+GYDMB9GsB+z9h4 ngKMOVsx8HDe4EH+ewjqyv/VxiESzhTMA/ZMBQX3vxcZTnVX81QTG9C5ruPU8alpI0Bit6oDuNLD1 zBnI7PTylQN4SVH3+dUjGX/qts+ENWIuM7lrEwgWGe92PMOyhy8Is1OYNRR1vUk6QkmaUDSgXNST+ TVIftYk4pcRRU5wuiOzK761nSR0Qhyf6Df2i70jFFKmI442sooajJeN0u1LuYdBmCsNu41uwsEtPA Q4RhLspV6Z+EzZfXNzMKeuI5UTTsq3tZQGTwStz+HwruTuCXA5ozunLdojgP+QDstD/GZcD1Sag7B 6mKnOKGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiqLD-0006LO-0k; Wed, 10 Jun 2020 02:19:47 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiqLA-0006Kk-DW for linux-arm-kernel@lists.infradead.org; Wed, 10 Jun 2020 02:19:45 +0000 Received: by mail-ed1-x544.google.com with SMTP id g1so258872edv.6 for ; Tue, 09 Jun 2020 19:19:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=6nDD9b7w8r1Mr/3MxkpIoE8zWpfhH3upQWRgRKaz8Zc=; b=d8fXfi1l7KInOy0Riqv289V5I5J1ZgSHL1mnqhUsN3TjXORhR79t8BUP4noaM6wxaV oF4HRekWinwy8NGtF9jeedNMhsCBi4m+sXOFRMrd4zvoeaAFaLCp+bO5Vs9NADVkdVmb E8XhMxF9b8v9mq893gxQNCngsZ/XC2oFr+hcO+higI+G2hcc+rErDQ3k1LLqDGmYSMIb WvswuoE/M1rnLHZyRUGJlOBg6FMpqstb0DLvcg2oOGa9ueadZj5PNTIKZ7JeNDh/XzyT EOky1jWF3pqojumstOj6V70bDCg4u20Tv8vBfPXCCddfq08EKytUPg24PfOscZ4ZNv/J eCZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6nDD9b7w8r1Mr/3MxkpIoE8zWpfhH3upQWRgRKaz8Zc=; b=kZYeqCM0/gbsflwk4p+9X7C78CCl3UB3WEFZUUsEXKNhJhw+h73fJHoYkNG27nW9Xh TMOHL9noEIwykVLFb3SK/k0dGghKFqDiEozlqDoOgqdPGx27IidqjmmninUfG6k1eC2+ aVRYTYZUvl+gJHWJmC3apYkVFYqkezZ3OQsnDRXgHtX7oilg3cfxJ7OKWv/60YW5ksZE 5T+wggjK/MhsdFqODIrJdCeTipKfG4ilnCX2Gv72bckXaO+1UvBD0tE8oXPoHNH4PiSG DZUL1dfeHKM+jX7PhWdDM0cshu8CRBl7XD2eDpDtfdrDXN12obFWj5+6IAkldimqh3WG 9tCQ== X-Gm-Message-State: AOAM530KTNMcBKHOxj8083LFmqQLj988OUIERfclBoQ1wC2z7acwd1bi mIc97xgEjs9lSfi6zZu3Jxwx5Ctn X-Google-Smtp-Source: ABdhPJyHM8AkM6LFw1w6gnIiVHMouyYrPLgZFtrZzLehkjZn/vUa+ZeZVaI4/d8rIky9PTihQBilQA== X-Received: by 2002:a50:b022:: with SMTP id i31mr595400edd.301.1591755580360; Tue, 09 Jun 2020 19:19:40 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id ss4sm14296639ejb.63.2020.06.09.19.19.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2020 19:19:39 -0700 (PDT) Subject: Re: [PATCH 2/4] soc: bcm: add BCM63xx power domain driver To: =?UTF-8?Q?=c3=81lvaro_Fern=c3=a1ndez_Rojas?= , hauke@hauke-m.de, zajec5@gmail.com, tsbogend@alpha.franken.de, robh+dt@kernel.org, jonas.gorski@gmail.com, bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20200609105244.4014823-1-noltari@gmail.com> <20200609105244.4014823-3-noltari@gmail.com> From: Florian Fainelli Message-ID: <13cc694b-c643-0f68-e510-062df5352eaa@gmail.com> Date: Tue, 9 Jun 2020 19:19:33 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200609105244.4014823-3-noltari@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200609_191944_478894_28A3AED4 X-CRM114-Status: GOOD ( 10.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiA2LzkvMjAyMCAzOjUyIEFNLCDDgWx2YXJvIEZlcm7DoW5kZXogUm9qYXMgd3JvdGU6Cj4g QkNNNjMxOCwgQkNNNjMyOCwgQkNNNjM2MiBhbmQgQkNNNjMyNjggU29DcyBoYXZlIGEgcG93ZXIg ZG9tYWluIGNvbnRyb2xsZXIKPiB0byBlbmFibGUvZGlzYWJsZSBjZXJ0YWluIGNvbXBvbmVudHMg aW4gb3JkZXIgdG8gc2F2ZSBwb3dlci4KPiAKPiBTaWduZWQtb2ZmLWJ5OiDDgWx2YXJvIEZlcm7D oW5kZXogUm9qYXMgPG5vbHRhcmlAZ21haWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3NvYy9iY20v S2NvbmZpZyAgICAgICAgIHwgICA4ICsKPiAgZHJpdmVycy9zb2MvYmNtL01ha2VmaWxlICAgICAg ICB8ICAgMSArCj4gIGRyaXZlcnMvc29jL2JjbS9iY202M3h4LXBvd2VyLmMgfCAzNzQgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysKCkkgd291bGQgY3JlYXRlIGRyaXZlcnMvc29jL2Jj bS9iY202M3h4IGJlY2F1c2UgdGhlcmUgYXJlIGxpa2VseSBnb2luZyB0bwpiZSBtb3JlIGNoYW5n ZXMgZm9yIEJDTTYzeHggRFNMIFNPQ3MgaW4gdGhlIGZ1dHVyZSB0aGF0IHdvdWxkIGxhbmQKdGhl cmUsIGZvciBpbnN0YW5jZSB0aGUgQkNNNjMxMzggYW5kIG5ld2VyIFNvQ3MgaGF2ZSBhbiBlbnRp cmVseQpkaWZmZXJlbnQgcmVzZXQgY29udHJvbGxlciB1c2luZyB0aGUgb24tY2hpcCBtaWNybyBj b250cm9sbGVyIHRoYXQgd291bGQKYmUgbGFuZGluZyB0aGVyZS4KCkNhbiB5b3UgYWxzbyBtYWtl IHN1cmUgdGhhdCB0aGUgTUFJTlRBSU5FUlMgZmlsZSBzdGlsbCBtYXRjaGVzIHRoYXQKbG9jYXRp b24/CgpXaXRoIHJlc3BlY3QgdG8gdGhlIGNvZGUsIGdpdmVuIHRoYXQgeW91IGhhdmUgZGVmaW5l ZCAjcmVzZXQtY2VsbHMgPSA8MT4KaW4gdGhlIERldmljZSBUcmVlIGJpbmRpbmcsIEkgd291bGQg ZXhwZWN0IHRoYXQgeW91IGNyZWF0ZSBhIGhlYWRlcgp1bmRlciBpbmNsdWRlL2R0LWJpbmRpbmdz LyB3aGljaCBkZWZpbmVzIGNvbnN0YW50cyBmb3IgdGhlIHZhcmlvdXMgU29Dcwp3aGljaCB5b3Ug YXJlIHRoZW4gdXNpbmcgd2l0aGluIHlvdXIgcG93ZXIgZG9tYWluIHByb3ZpZGVyIGRyaXZlci4K YmNtMjgzNS1wb3dlci5jIGlzIGEgZ29vZCBleGFtcGxlIG9mIGhvdyB0aGlzIHdvcmtzIGZvciBp bnN0YW5jZS4KLS0gCkZsb3JpYW4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK