From: "Colin King (gmail)" <colin.i.king@gmail.com>
To: "André Almeida" <andrealmeid@igalia.com>
Cc: Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, Christian Brauner <brauner@kernel.org>,
Gabriel Krisman Bertazi <gabriel@krisman.be>,
Andrew Morton <akpm@linux-foundation.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] mm: shmem: Fix error checking on utf8_parse_version failures
Date: Tue, 12 Nov 2024 10:12:24 +0000 [thread overview]
Message-ID: <13db01a1-1c8b-4d56-ac2d-9f39082c2644@gmail.com> (raw)
In-Reply-To: <3b865b4a-5d82-4d11-a60c-f4bea6cd25c0@igalia.com>
On 12/11/2024 10:06, André Almeida wrote:
> Hi Colin,
>
> Em 12/11/2024 06:54, Colin Ian King escreveu:
>> Currently the error check on the call to utf8_parse_version is always
>> false because version is an unsigned int and this can never be less
>> than zero. Because version is required to be an unsigned int, fix the
>> issue by casting it to int just for the error check.
>
> Why is it required to be an unsigned int?
It's being passed to various functions that expect unsigned int, so I
presume it was intended to be of that type.
Colin
>
>>
>> Fixes: 58e55efd6c72 ("tmpfs: Add casefold lookup support")
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> Another fix was already sent: https://lore.kernel.org/lkml/20241111-
> unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com/
prev parent reply other threads:[~2024-11-12 10:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 9:54 [PATCH][next] mm: shmem: Fix error checking on utf8_parse_version failures Colin Ian King
2024-11-12 10:06 ` André Almeida
2024-11-12 10:12 ` Colin King (gmail) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13db01a1-1c8b-4d56-ac2d-9f39082c2644@gmail.com \
--to=colin.i.king@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrealmeid@igalia.com \
--cc=brauner@kernel.org \
--cc=gabriel@krisman.be \
--cc=hughd@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.