From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sat, 27 Feb 2021 13:51:52 +0100 Subject: [PATCH] ARM: imx: imx8mn-ddr4-evk: Add ethernet support In-Reply-To: References: <20210226221429.344478-1-marex@denx.de> Message-ID: <13dbfd79-2ef7-d2b2-e28d-b3a186db4700@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 2/27/21 8:54 AM, Jagan Teki wrote: > Hi Marek, > > On Sat, Feb 27, 2021 at 3:44 AM Marek Vasut wrote: >> >> Add support for ethernet on the imx8mn-ddr4-evk. >> >> Signed-off-by: Marek Vasut >> Cc: Fabio Estevam >> Cc: Peng Fan >> Cc: Stefano Babic >> --- >> arch/arm/dts/imx8mn-evk.dtsi | 1 + >> board/freescale/imx8mn_evk/imx8mn_evk.c | 41 +++++++++++++++++++++++-- >> configs/imx8mn_ddr4_evk_defconfig | 8 +++++ >> 3 files changed, 47 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/dts/imx8mn-evk.dtsi b/arch/arm/dts/imx8mn-evk.dtsi >> index 76d042a4cf0..416fadb22b1 100644 >> --- a/arch/arm/dts/imx8mn-evk.dtsi >> +++ b/arch/arm/dts/imx8mn-evk.dtsi >> @@ -53,6 +53,7 @@ >> pinctrl-0 = <&pinctrl_fec1>; >> phy-mode = "rgmii-id"; >> phy-handle = <ðphy0>; >> + phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>; > > I believe this is phy reset-gpio to be part of mdio child node. any > idea why it added in fec1 node? Try $ git grep phy-reset drivers/net/ , that should clarify it all. In short, FEC in U-Boot still uses legacy bindings.