From: Paran Lee <p4ranlee@gmail.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, shjy180909@gmail.com,
austindh.kim@gmail.com
Subject: Re: [PATCH] irqdesc: Fail check on early_irq_init allocation.
Date: Mon, 13 Nov 2023 00:21:43 +0900 [thread overview]
Message-ID: <13dfd533-daf4-3b35-3d68-5c72a294db3c@gmail.com> (raw)
In-Reply-To: <87edgvxb56.wl-maz@kernel.org>
On 2023-11-13 오전 12:08, Marc Zyngier wrote:
Thanks for the great feedback Marc!
The review has taught me a lot of things I didn't realized
I'll try to do better in the direction you suggested. To be useful.
> A much better idea would be to *get rid* of early allocation failures
> altogether, by moving all architectures to SPARSE_IRQ and making sure
> that NR_LEGAY_IRQ is always zero, meaning there is nothing to
> allocate. That would be something useful.
>
> But adding random BUG_ON() based on the dogma that all allocations
> must be checked doesn't bring value to the kernel as a whole.
>
> M.
Thanks so much!
BR
Paran Lee
prev parent reply other threads:[~2023-11-12 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 17:00 [PATCH] irqdesc: Fail check on early_irq_init allocation Paran Lee
2023-11-12 14:00 ` Marc Zyngier
2023-11-12 14:19 ` Paran Lee
2023-11-12 15:08 ` Marc Zyngier
2023-11-12 15:21 ` Paran Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13dfd533-daf4-3b35-3d68-5c72a294db3c@gmail.com \
--to=p4ranlee@gmail.com \
--cc=austindh.kim@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=shjy180909@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.