From: Zhang Rui <rui.zhang@intel.com>
To: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: bhelgaas@google.com, matthew.garrett@nebula.com,
rafael.j.wysocki@intel.com, dmitry.torokhov@gmail.com,
Zhang Rui <rui.zhang@intel.com>
Subject: [PATCH V6 01/11] ACPI: introduce .match() callback for ACPI scan handler
Date: Thu, 15 May 2014 14:44:06 +0800 [thread overview]
Message-ID: <1400136256-2218-2-git-send-email-rui.zhang@intel.com> (raw)
In-Reply-To: <1400136256-2218-1-git-send-email-rui.zhang@intel.com>
Currently, ACPI scan handler uses strcmp() to match device ids
and scan handler ids.
When converting PNPACPI enumeration into a scan handler, which I will do
later in this patch set, the current code becomes not flexible enough
because ACPI pnp scan handler requires wildcase and case insensitive support.
Thus a per scan handler .match() callback is introduced in this patch,
so that specified scan handler can have more flexible matching mechanism
by introduce its own .match() callback.
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
drivers/acpi/scan.c | 17 +++++++++++------
include/acpi/acpi_bus.h | 1 +
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 7efe546..e46e51c 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -1974,14 +1974,19 @@ static bool acpi_scan_handler_matching(struct acpi_scan_handler *handler,
const struct acpi_device_id *devid;
for (devid = handler->ids; devid->id[0]; devid++)
- if (!strcmp((char *)devid->id, idstr)) {
- if (matchid)
- *matchid = devid;
-
- return true;
- }
+ if (handler->match) {
+ if (handler->match(idstr, (char *)devid->id))
+ goto success;
+ } else
+ if (!strcmp((char *)devid->id, idstr))
+ goto success;
return false;
+
+success:
+ if (matchid)
+ *matchid = devid;
+ return true;
}
static struct acpi_scan_handler *acpi_scan_match_handler(char *idstr,
diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
index 84a2e29..ba679af 100644
--- a/include/acpi/acpi_bus.h
+++ b/include/acpi/acpi_bus.h
@@ -131,6 +131,7 @@ static inline struct acpi_hotplug_profile *to_acpi_hotplug_profile(
struct acpi_scan_handler {
const struct acpi_device_id *ids;
struct list_head list_node;
+ int (*match)(char *devid, char *handler_id);
int (*attach)(struct acpi_device *dev, const struct acpi_device_id *id);
void (*detach)(struct acpi_device *dev);
void (*bind)(struct device *phys_dev);
--
1.8.3.2
next prev parent reply other threads:[~2014-05-15 6:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 6:44 [PATCH V6 00/11] ACPI: ACPI enumeration rework Zhang Rui
2014-05-15 6:44 ` Zhang Rui
2014-05-15 6:44 ` Zhang Rui [this message]
2014-05-15 6:44 ` [PATCH V6 02/11] PNPACPI: use whilte list for pnpacpi device enumeration Zhang Rui
2014-05-15 6:44 ` [PATCH V6 03/11] ACPI: remove ids that does not comply with the ACPI PNP id rule Zhang Rui
2014-05-15 6:44 ` [PATCH V6 04/11] ACPI: remove unsupported serial PNP ids from acpi pnp scan handler id lsit Zhang Rui
2014-05-15 6:44 ` [PATCH V6 05/11] ACPI: introduce dummy container scan handler Zhang Rui
2014-05-15 6:44 ` [PATCH V6 06/11] ACPI: introduce dummy memory hotplug " Zhang Rui
2014-05-15 6:44 ` [PATCH V6 07/11] ACPI: introduce dummy lpss " Zhang Rui
2014-05-21 8:48 ` Mika Westerberg
2014-05-21 14:56 ` Zhang Rui
2014-05-22 9:57 ` Mika Westerberg
2014-05-22 9:57 ` Mika Westerberg
2014-05-15 6:44 ` [PATCH V6 08/11] ACPI: introduce platform_id flag Zhang Rui
2014-05-15 6:44 ` [PATCH V6 09/11] ACPI: introduce flag .is_master_device Zhang Rui
2014-05-21 8:52 ` Mika Westerberg
2014-05-21 11:10 ` Rafael J. Wysocki
2014-05-21 11:04 ` Mika Westerberg
2014-05-21 11:59 ` Rafael J. Wysocki
2014-05-21 15:09 ` Zhang Rui
2014-05-22 8:08 ` Mika Westerberg
2014-05-22 8:08 ` Mika Westerberg
2014-05-21 14:43 ` Zhang Rui
2014-05-21 14:43 ` Zhang Rui
2014-05-22 8:51 ` Mika Westerberg
2014-05-22 14:26 ` Zhang Rui
2014-05-15 6:44 ` [PATCH V6 10/11] ACPI: use platform bus as the default bus for _HID enumeration Zhang Rui
2014-05-22 9:58 ` Mika Westerberg
2014-05-15 6:44 ` [PATCH V6 11/11] ACPI: introduce acpi platform exclude id list Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400136256-2218-2-git-send-email-rui.zhang@intel.com \
--to=rui.zhang@intel.com \
--cc=bhelgaas@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.