From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH V5 03/32] xl / libxl: push VCPU affinity pinning down to libxl Date: Fri, 16 May 2014 10:10:53 +0200 Message-ID: <1400227853.5960.8.camel@Solace> References: <1400018054-26038-1-git-send-email-wei.liu2@citrix.com> <1400018054-26038-4-git-send-email-wei.liu2@citrix.com> <1400172319.883.29.camel@kazak.uk.xensource.com> <20140515170650.GB10525@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4204434860372600474==" Return-path: In-Reply-To: <20140515170650.GB10525@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.jackson@eu.citrix.com, Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============4204434860372600474== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-vUJtKuuW/yFDt6Ym3Zna" --=-vUJtKuuW/yFDt6Ym3Zna Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On gio, 2014-05-15 at 18:06 +0100, Wei Liu wrote: > On Thu, May 15, 2014 at 05:45:19PM +0100, Ian Campbell wrote: > > On Tue, 2014-05-13 at 22:53 +0100, Wei Liu wrote: > >=20 > > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > > > index 0dfafe7..7b0901c 100644 > > > --- a/tools/libxl/libxl_types.idl > > > +++ b/tools/libxl/libxl_types.idl > > > @@ -305,6 +305,7 @@ libxl_domain_build_info =3D > > Struct("domain_build_info",[ > > > ("avail_vcpus", libxl_bitmap), > > > ("cpumap", libxl_bitmap), > > > ("nodemap", libxl_bitmap), > > > + ("vcpu_affinity", libxl_key_value_list), > > >=20 > > Is a key value list really the best way to represent this? At first > > glance it seems like an array would be more suitable? > >=20 > > I've glanced through the rest on the assumption you have a convincing > > reason why it should be a kvp list. > >=20 >=20 > How can you effectively skip pinning a VCPU if it's an array? I can have > [ '0': '1', '3': '3' ] in KVL, but not able to represent it in an array > [ '1', ?, ?, '3' ]. >=20 I think I agree with Wei. When everything was in xl, an array is what was being used, marking with '-1' (IIRC) the spots of not-to-be-pinned vcpus. Now that we're passing the info to libxl, that would mean always passing an array of max_vcpus elements, even if the to-be-pinned vcpus are only 2 or 3. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-vUJtKuuW/yFDt6Ym3Zna Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlN1yA0ACgkQk4XaBE3IOsRDvgCfYCrv0JDHJVk4DAZlG+ZCMv0K QcgAn2yIG7v9PqhXvQ8/lNck6LFlLx9K =Rzz1 -----END PGP SIGNATURE----- --=-vUJtKuuW/yFDt6Ym3Zna-- --===============4204434860372600474== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4204434860372600474==--